Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] Move RFieldVisitor out of Experimental #18031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ntuple] Move RFieldVisitor out of Experimental #18031

wants to merge 1 commit into from
+124 −137

Conversation

silverweed
Copy link
Contributor

And move its child classes to Internal.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed
[ntuple] Move RFieldVisitor out of Experimental
7bbe0c6 
And move its child classes to Internal
@silverweed silverweed requested review from hahnjo, pcanal and enirolf March 18, 2025 10:10
@silverweed silverweed self-assigned this Mar 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

Test Results

    20 files      20 suites   5d 0h 51m 34s ⏱️
 2 726 tests  2 726 ✅ 0 💤 0 ❌
52 591 runs  52 591 ✅ 0 💤 0 ❌

Results for commit 7bbe0c6.

♻️ This comment has been updated with latest results.

hahnjo
hahnjo approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

enirolf
enirolf approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahnjo hahnjo hahnjo approved these changes

@enirolf enirolf enirolf approved these changes

@pcanal pcanal Awaiting requested review from pcanal

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@linev linev Awaiting requested review from linev linev is a code owner

@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

Assignees

@silverweed silverweed

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverweed @hahnjo @enirolf