-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[clang] Forward TPL of NestedNameSpecifier #18464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 19 files 19 suites 4d 7h 4m 29s ⏱️ Results for commit fc8c421. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I see the solution I remember that passing the TPL also helped in a few other occasions. I wished I have remembered that sooner. LGTM!
This avoids type suffixes for integer constants when the type can be inferred from the template parameter. Closes root-project#18363
Co-authored-by: Philippe Canal <[email protected]>
I'd prefer if both commits are squashed makes the history clearer in terms of what was fixed and what was broken. |
While I agree in general, I don't want to do this here because we want to backport to at least 6.36 and we still have the separate |
Probably we can adjust the backport instead? |
Hrm, it's extra work and probably requires me to edit |
This avoids type suffixes for integer constants when the type can be inferred from the template parameter.
Closes #18363