Skip to content

[io] test for renaming with unversioned classes #18666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[io] test for renaming with unversioned classes #18666

wants to merge 1 commit into from

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented May 9, 2025 •
edited
Loading

This Pull request:

Changes or fixes:

Test for #14491
Closes #14491

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury requested a review from dpiparo as a code owner May 9, 2025 07:26
ferdymercury
ferdymercury commented May 9, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025 •
edited
Loading

Test Results

    22 files      22 suites   3d 15h 1m 58s ⏱️
 3 689 tests  3 688 ✅ 0 💤 1 ❌
79 262 runs  79 260 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 5f53f97.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury added this to the 6.38.00 milestone May 15, 2025
@ferdymercury ferdymercury requested review from pcanal and jblomer August 12, 2025 09:17
@ferdymercury ferdymercury requested a review from linev August 26, 2025 20:46
@linev
Copy link
Member

linev commented Aug 27, 2025

Instead providing root file I would add writedata.C macro and execute it.
So one can clearly see that kind of data is produced.

@ferdymercury ferdymercury requested a review from bellenot as a code owner August 27, 2025 08:19
@ferdymercury
Copy link
Collaborator Author

Instead providing root file I would add writedata.C macro and execute it.
So one can clearly see that kind of data is produced.

Thanks, good idea. Could you verify that I set the FIXTURES flag correctly? Since I am not used to those yet.

@ferdymercury ferdymercury force-pushed the renamtest branch 2 times, most recently from 2e29f59 to 2ea8e5a Compare August 27, 2025 08:28
@linev
Copy link
Member

linev commented Aug 27, 2025

Fixtures configured correctly.
I let @pcanal approve PR.

@ferdymercury
Copy link
Collaborator Author

It seems it only fails on Windows. No idea why...

@linev
Copy link
Member

linev commented Aug 27, 2025

It seems it only fails on Windows. No idea why...

Looks like difference in file content.
May be some variables not initialized when file is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@pcanal pcanal Awaiting requested review from pcanal

@jblomer jblomer Awaiting requested review from jblomer

@linev linev Awaiting requested review from linev

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pcanal pcanal

Labels
affects:master in:Testing
Projects
None yet
Milestone
6.38.00
Development

Successfully merging this pull request may close these issues.

Conversion StreamerInfo not properly found if classes are unversioned.
3 participants
@ferdymercury @linev @pcanal