-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[test] add test/tutorial for TFractionFitter #19243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 7h 36m 57s ⏱️ For more details on these failures, see this check. Results for commit 14359e2. ♻️ This comment has been updated with latest results. |
This PR is really good, thanks for proposing these changes. Maybe, and this is up to @martamaja10 also to say, the tutorial seems a bit old fashioned, with all the pointers, new and deletes and could use a slight modernisation... |
Hi @ferdymercury, Thanks a lot for this nice PR! I agree with Danilo, maybe some "modernisation" would be nice, so what it really involves is, for example changing lines like: Cheers, |
Another thing that would be super super nice to add to this PR is an entry in the fit tutorials table which is defined in this file: https://github.com/root-project/root/blob/master/tutorials/math/fit/index.md. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing my previous comments. Would it be possible to also squash the commits (we could have one for adding the new tutorial and one for adding the tests) and run a git clang-format at the end (I can see that the CI is complaining about the formatting: https://github.com/root-project/root/actions/runs/16625830587/job/47041863011?pr=19243)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this nice PR!
Hi again @ferdymercury, sorry for being picky, one very very last thing before merging, the clang-format still complains. The two new files after clang-formatting should look like the ones under this link: https://cernbox.cern.ch/s/RzAxbAJbAVb60Io |
taken from https://its.cern.ch/jira/browse/ROOT-9330 [test] add new test to CMakeList [test] proper memory cleanup [test] fix test failure [test] not needed warning capture? [test] update test catches [test] avoid the use of new and delete modernize as suggested by danilo and marta
Fixes https://its.cern.ch/jira/browse/ROOT-9330 [tutorial] avoid use of new and delete as suggested by marta and danilo and some formatting [tutorials] add fraction-fitter tutorial to Hist1D-Fit table as suggested by marta [nfc] mention tutorial in class documentation
[nfc] mention roofit alternative
My bad, I totally forgot that step :) Fixed now. |
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-9330
This would be also a good excuse to revive #18090
Checklist: