-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cmake][win] Fix conda build (with external LLVM & Clang) #19652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you extend the commit log to describe the symptoms this fixes? (It smells like the external Clang's cmake setup/find_package is not defining enough for Windows)
Test Results 21 files 21 suites 3d 15h 2m 9s ⏱️ For more details on these failures, see this check. Results for commit 25e1431. |
Thanks Philippe, but I think something is still missing. I'm trying the tests (still in conda and now I have the same kind of error:
So I'll try to find the proper solution... |
superseded by #19713 |
No description provided.