Skip to content

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Aug 21, 2025

This Pull request:

renames RInvalidField::RCategory to RInvalidField::ECategory, more appropriate for an enum.
Marks RCategory as deprecated, to be removed in 6.42.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed requested review from hahnjo and enirolf August 21, 2025 13:39
@silverweed silverweed self-assigned this Aug 21, 2025
@silverweed silverweed requested a review from jblomer as a code owner August 21, 2025 13:39
Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but see warnings)

Copy link

github-actions bot commented Aug 21, 2025

Test Results

    21 files      21 suites   3d 11h 44m 34s ⏱️
 3 561 tests  3 424 ✅  0 💤 137 ❌
73 028 runs  72 874 ✅ 17 💤 137 ❌

For more details on these failures, see this check.

Results for commit eeed4e9.

♻️ This comment has been updated with latest results.

@silverweed silverweed force-pushed the rinvalidfield_category branch from c1ec899 to f7af6a4 Compare August 22, 2025 06:44
@silverweed silverweed merged commit e7d46b7 into root-project:master Aug 25, 2025
43 of 48 checks passed
@silverweed silverweed deleted the rinvalidfield_category branch August 25, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants