[hist] Check argument types during ComputeGlobalIndex
#20050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 4d 0h 5m 33s ⏱️ For more details on these failures, see this check. Results for commit 48092ca. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Oct 8, 2025
This prepares for future axis types that accept different argument types (in particular RCategoricalAxis), where we can only decide at run-time if the parameters match the axis configuration. However, because the type check is evaluated at compile-time, there is no performance penalty for cases where the type is convertible.
hahnjo
force-pushed
the
hist-argument-type
branch
from
60ebcd6 to
48092ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for future axis types that accept different argument types (in particular
RCategoricalAxis), where we can only decide at run-time if the parameters match the axis configuration. However, because the type check is evaluated at compile-time, there is no performance penalty for cases where the type is convertible.