Fix warnings when compiling with Clang 21 #20080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
dpiparo,
jblomer,
lmoneta and
pcanal
as code owners
Test Results 22 files 22 suites 3d 17h 8m 57s ⏱️ For more details on these failures, see this check. Results for commit 5143dcd. ♻️ This comment has been updated with latest results. |
vepadulano
requested changes
Oct 11, 2025
Fixing warnings like:
```txt
In file included from /home/rembserj/code/root/root_src/core/metacling/src/TClingCallFunc.cxx:32:
/home/rembserj/code/root/root_src/core/metacling/src/TCling.h:372:17: warning: virtual method 'GetFunctionName' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier]
372 | virtual void GetFunctionName(const clang::Decl *decl, std::string &name) const;
| ^
1 warning generated.
```
or
```
/home/rembserj/code/root/root_src/tree/ntuple/test/ntuple_parallel_writer.cxx:97:29: warning: variable 'pt1' is uninitialized when passed as a const pointer argument here [-Wuninitialized-const-pointer]
97 | e1->BindRawPtr("pt", &pt1);
|
```
guitargeek
force-pushed
the
clang_21_warnings
branch
from
bd9681b to
5143dcd
Compare
|
Thanks @vepadulano for the review! I have addressed your comments. |
vepadulano
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing warnings like:
or