Skip to content

[build] Enable Davix in Python wheels #20360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vepadulano wants to merge 6 commits into
base: master
Choose a base branch
from
+11 −11
Open

[build] Enable Davix in Python wheels #20360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
737e30e
[build] Enable Davix in Python wheels
vepadulano Nov 9, 2025
c161542
[build] Increase wheel version
vepadulano Jan 9, 2026
bcff472
[build] add Python 3.14 to wheel builds
vepadulano Jan 9, 2026
888eb80
[build] Reflect recent minimum Python 3.10 requirement
vepadulano Jan 9, 2026
9c8902c
[build] Update cibuildwheel action version
vepadulano Jan 9, 2026
fc0c69d
[build] Install CA certificates for tutorials using Davix
vepadulano Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cibuildwheel-impl/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
using: "composite"
steps:
- name: Build wheel
uses: pypa/cibuildwheel@v3.0.1
uses: pypa/cibuildwheel@v3.3.1
env:
CIBW_BUILD: ${{ inputs.build-tag }}

Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/python_wheel_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
strategy:
fail-fast: false
matrix:
target: [cp310-manylinux_x86_64, cp311-manylinux_x86_64, cp312-manylinux_x86_64, cp313-manylinux_x86_64]
target: [cp310-manylinux_x86_64, cp311-manylinux_x86_64, cp312-manylinux_x86_64, cp313-manylinux_x86_64, cp314-manylinux_x86_64]
name: ${{ matrix.target }}
steps:
- uses: actions/checkout@v4
Expand All @@ -42,7 +42,7 @@
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
name: test-wheel-cp${{ matrix.python-version }}
steps:
- uses: actions/checkout@v4
Expand All @@ -58,8 +58,11 @@
with:
python-version: ${{ matrix.python-version }}

- name: Install CA certificates for Davix
run: sudo apt-get install -y ca-certificates

- name: Install produced wheel
run: |

Check failure on line 65 in .github/workflows/python_wheel_build.yml

View workflow job for this annotation

GitHub Actions / lint-action-files 

shellcheck reported issue in this script: SC2012:info:3:9: Use find instead of ls to better handle non-alphanumeric filenames
ls -R wheels
PY_VER=$(python -c "import sys; print(f'cp{sys.version_info.major}{sys.version_info.minor}')")
WHEEL=$(ls wheels/*${PY_VER}*.whl | head -n 1)
Expand Down Expand Up @@ -92,7 +95,7 @@
uses: actions/setup-python@v5

- name: Create PEP503-compliant wheel registry
run: |

Check failure on line 98 in .github/workflows/python_wheel_build.yml

View workflow job for this annotation

GitHub Actions / lint-action-files 

shellcheck reported issue in this script: SC2035:info:2:4: Use ./*glob* or -- *glob* so names with dashes won't become options
mkdir -p wheelhouse
mv *.whl wheelhouse
python -m pip install --upgrade pip
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ requires = ["cmake", "setuptools<72", "wheel", "numpy"]

[project]
name = "ROOT"
version = "0.1a9"
requires-python = ">=3.9"
version = "0.1a11"
requires-python = ">=3.10"
maintainers = [
{name = "Vincenzo Eduardo Padulano", email = "[email protected]"}
]
Expand All @@ -27,4 +27,4 @@ manylinux-x86_64-image = "manylinux_2_28"

# Install system libraries
[tool.cibuildwheel.linux]
before-all = "dnf install -y epel-release && /usr/bin/crb enable && dnf install -y openssl-devel libX11-devel libXpm-devel libXft-devel libXext-devel libuuid-devel libjpeg-devel giflib-devel"
before-all = "dnf install -y epel-release && /usr/bin/crb enable && dnf install -y openssl-devel libX11-devel libXpm-devel libXft-devel libXext-devel libuuid-devel libjpeg-devel giflib-devel libxml2-devel"
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ def run(self):
# see https://peps.python.org/pep-0513/#libpythonx-y-so-1
# - thisroot_scripts: the thisroot.* scripts are broken if CMAKE_INSTALL_PYTHONDIR!=CMAKE_INSTALL_LIBDIR
"-Dtmva-pymva=OFF -Dtpython=OFF -Dthisroot_scripts=OFF "
"-Dbuiltin_nlohmannjson=ON -Dbuiltin_tbb=ON -Dbuiltin_xrootd=ON " # builtins
"-Dbuiltin_nlohmannjson=ON -Dbuiltin_tbb=ON -Dbuiltin_xrootd=ON -Dbuiltin_davix=ON " # builtins
"-Dbuiltin_lz4=ON -Dbuiltin_lzma=ON -Dbuiltin_zstd=ON -Dbuiltin_xxhash=ON " # builtins
"-Dpyroot=ON -Ddataframe=ON -Dxrootd=ON -Dssl=ON -Dimt=ON "
"-Dpyroot=ON -Ddataframe=ON -Dxrootd=ON -Ddavix=ON -Dssl=ON -Dimt=ON "
"-Droofit=ON -Dmathmore=ON -Dbuiltin_fftw3=ON -Dbuiltin_gsl=ON "
# Next 4 paths represent the structure of the target binaries/headers/libs
# as the target installation directory of the Python environment would expect
Expand Down
3 changes: 0 additions & 3 deletions test/wheels/test_tutorials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
subdirs = ["analysis/dataframe", "analysis/tree", "hist", "io/ntuple", "roofit/roofit"]

SKIP_TUTORIALS = {
"ntpl004_dimuon.C", # requires reading remote data via HTTP
"ntpl008_import.C", # requires reading remote data via HTTP
"ntpl011_global_temperatures.C", # requires reading remote data via HTTP
"distrdf004_dask_lxbatch.py", # only works on lxplus
"_SQlite", # requires SQLite, not supported yet in ROOT wheels
"h1analysisProxy.C", # helper macro, not meant to run standalone
Expand Down
Loading