Skip to content

Fix: Suppress -Wshadow warnings in headers on macOS (Fixes #20790) #20793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aryansri05 wants to merge 44 commits into from
Closed

Fix: Suppress -Wshadow warnings in headers on macOS (Fixes #20790) #20793

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
34a0eee
Fix: Suppress -Wshadow warnings in headers on macOS (Fixes #20790)
Jan 2, 2026
d6666b8
Style: Remove extra newline before footer to satisfy clang-format
Jan 3, 2026
aefdf3f
Refactor: Narrow scope of -Wshadow suppression to specific enums in 9…
Jan 4, 2026
4698a8c
Revert 4 files to original upstream state
Jan 5, 2026
b412441
Refactor: Add GCC support for -Wshadow suppression
Jan 5, 2026
691cdf1
Rename constructor arguments to resolve shadowing and remove pragma s…
Jan 9, 2026
4442723
Style cleanup: Fix TClass shadowing, revert TAttMarker whitespace, re…
Jan 9, 2026
696a0d1
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
c498219
Style cleanup: Fix copyright header formatting in TClass and TAttText
Jan 9, 2026
7d9de29
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
69b37d7
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
b1debb2
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
35b15a4
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
c6d8bf3
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
18dd104
Update core/base/inc/TAttText.h
aryansri05 Jan 9, 2026
6fe8064
Update core/base/inc/TAttText.h
aryansri05 Jan 9, 2026
e24d74e
Update core/base/inc/TSystem.h
aryansri05 Jan 9, 2026
5075119
Update core/base/inc/TSystem.h
aryansri05 Jan 9, 2026
3c355c2
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
bad85c0
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
f56079d
Update core/base/src/TAttText.cxx
aryansri05 Jan 9, 2026
3f3d0c9
Update core/base/src/TAttText.cxx
aryansri05 Jan 9, 2026
eac1c2b
Update io/io/inc/TFile.h
aryansri05 Jan 9, 2026
761e5cb
Update math/matrix/inc/TMatrixTSparse.h
aryansri05 Jan 9, 2026
9da9c3d
Update tree/tree/inc/TBranch.h
aryansri05 Jan 9, 2026
424b7b6
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
0e3588e
Update math/matrix/inc/TMatrixT.h
aryansri05 Jan 9, 2026
32f720e
Update math/matrix/inc/TMatrixT.h
aryansri05 Jan 9, 2026
de93436
Update math/matrix/inc/TMatrixTSparse.h
aryansri05 Jan 9, 2026
1c0fea7
Update math/matrix/inc/TMatrixTSym.h
aryansri05 Jan 9, 2026
de39f84
Update tree/tree/inc/TBranch.h
aryansri05 Jan 9, 2026
dc749f6
Update math/matrix/inc/TMatrixTSym.h
aryansri05 Jan 9, 2026
d8ca856
Update core/base/src/TAttText.cxx
aryansri05 Jan 9, 2026
c743796
Update core/meta/inc/TClass.h
aryansri05 Jan 9, 2026
2271329
Update core/meta/inc/TClass.h
aryansri05 Jan 9, 2026
f553e4a
Update core/meta/inc/TClass.h
aryansri05 Jan 9, 2026
5031a21
Update io/io/inc/TFile.h
aryansri05 Jan 9, 2026
206ad50
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
dad1300
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
cbdd1d8
Update core/base/inc/TAttMarker.h
aryansri05 Jan 9, 2026
7756fce
Update core/base/inc/TAttMarker.h
aryansri05 Jan 10, 2026
1aaf392
Update core/base/inc/TAttMarker.h
aryansri05 Jan 10, 2026
6a60d7d
Update core/base/inc/TAttMarker.h
aryansri05 Jan 12, 2026
16c795e
Update core/base/inc/TAttMarker.h
aryansri05 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/base/inc/TApplication.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/base:$Id$
// Author: Fons Rademakers 22/12/95

Expand Down Expand Up @@ -170,3 +174,7 @@ class TApplication : public TObject, public TQObject {
R__EXTERN TApplication *gApplication;

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
7 changes: 7 additions & 0 deletions core/base/inc/TAttMarker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/base:$Id$
// Author: Rene Brun 12/05/95

Expand Down Expand Up @@ -70,3 +74,6 @@ class TAttMarker {

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions core/base/inc/TSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/base:$Id$
// Author: Fons Rademakers 15/09/95

Expand Down Expand Up @@ -574,3 +578,7 @@ R__EXTERN TFileHandler *gXDisplay; // Display server (X11) input event handler


#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions core/base/inc/TVirtualX.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/base:$Id$
// Author: Fons Rademakers 3/12/95

Expand Down Expand Up @@ -339,3 +343,7 @@ R__EXTERN TVirtualX *(*gPtr2VirtualX)();
R__EXTERN TVirtualX *gGXBatch;

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions core/meta/inc/TClass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/meta:$Id$
// Author: Rene Brun 07/01/95

Expand Down Expand Up @@ -693,3 +697,7 @@ template <typename T> TClass *GetClass(const T * /* dummy */) { return TClass::G
}

#endif // ROOT_TClass

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions core/meta/inc/TInterpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/meta:$Id$
// Author: Fons Rademakers 01/03/96

Expand Down Expand Up @@ -584,3 +588,7 @@ inline ROOT::Internal::InterpreterMutexRegistrationRAII::~InterpreterMutexRegist
}

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions gui/gui/inc/TGFrame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/gui:$Id$
// Author: Fons Rademakers 03/01/98

Expand Down Expand Up @@ -609,3 +613,7 @@ class TGHeaderFrame : public TGHorizontalFrame {


#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions io/io/inc/TFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/io:$Id$
// Author: Rene Brun 28/11/94

Expand Down Expand Up @@ -483,3 +487,7 @@ inline Int_t TFile::GetCompressionSettings() const
}

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions math/matrix/inc/TMatrixT.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/matrix:$Id$
// Authors: Fons Rademakers, Eddy Offermann Nov 2003

Expand Down Expand Up @@ -364,3 +368,7 @@ template <class Element> void AMultBt(const Element * const ap,Int_t na,Int_t nc
const Element * const bp,Int_t nb,Int_t ncolsb,Element *cp);
} // inline namespace TMatrixTAutoloadOps
#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions math/matrix/inc/TMatrixTSparse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/matrix:$Id$
// Authors: Fons Rademakers, Eddy Offermann Feb 2004

Expand Down Expand Up @@ -285,3 +289,7 @@ template <class Element> TMatrixTSparse<Element> &ElementDiv (TMatrixTSparse<Ele
template <class Element> Bool_t AreCompatible(const TMatrixTSparse<Element> &m1,const TMatrixTSparse<Element> &m2,Int_t verbose=0);

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions math/matrix/inc/TMatrixTSym.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/matrix:$Id$
// Authors: Fons Rademakers, Eddy Offermann Nov 2003

Expand Down Expand Up @@ -283,3 +287,7 @@ template <class Element> TMatrixTSym<Element> &ElementMult(TMatrixTSym<Element>
template <class Element> TMatrixTSym<Element> &ElementDiv (TMatrixTSym<Element> &target,const TMatrixTSym<Element> &source);

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions net/net/inc/TSocket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/net:$Id$
// Author: Fons Rademakers 18/12/96

Expand Down Expand Up @@ -188,3 +192,7 @@ inline Int_t TSocket::GetCompressionSettings() const
}

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
8 changes: 8 additions & 0 deletions tree/tree/inc/TBranch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshadow"
#endif
// @(#)root/tree:$Id$
// Author: Rene Brun 12/01/96

Expand Down Expand Up @@ -328,3 +332,7 @@ inline bool TBulkBranchRead::SupportsBulkRead() const { return fParent.Support
} // ROOT

#endif

#if defined(__clang__)
#pragma clang diagnostic pop
#endif
Loading