[roottest] Fix build races #20883
Open
[roottest] Fix build races #20883
+39
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are important when building with GNU Make, to avoid looking at dependencies but always rebuild the target.
Commit f5fca06 added them for the ROOTTEST_GENERATE_* macros, but we also need them for manually registered build tests.
vepadulano
reviewed
Jan 14, 2026
| add_test(NAME ${GENERATE_DICTIONARY_TEST} | ||
| COMMAND ${CMAKE_COMMAND} --build ${CMAKE_BINARY_DIR} | ||
| --target ${ATLASLIKEDATAVECTOR_DICTNAME} ${ATLASLIKEDATAVECTOR_LIB}) | ||
| --target ${ATLASLIKEDATAVECTOR_DICTNAME}${fast} ${ATLASLIKEDATAVECTOR_LIB}${fast} -- ${always-make}) |
Member
There was a problem hiding this comment.
About this specific line, IIUC this PR #19344 should practically do the same thing by moving to using ROOTTEST_GENERATE_DICTIONARY which by default uses both ${fast} and ${always_make}. Since that PR is now working (just needs an approval), we could wait to merge that one and you could then rebase this one, or viceversa.
Member
Author
There was a problem hiding this comment.
Ok, let's do that. I will then rebase this PR.
hageboeck
approved these changes
Jan 14, 2026
bellenot
reviewed
Jan 14, 2026
| -- ${always-make}) | ||
| # --target ${targetname_libgen}${fast}) | ||
| set_property(TEST roottest-cling-dict-ROOT-8096-build PROPERTY ENVIRONMENT ${ROOTTEST_ENVIRONMENT}) | ||
| if(CMAKE_GENERATOR MATCHES Ninja AND NOT MSVC) |
Member
There was a problem hiding this comment.
It's not clear to me if the AND NOT MSVC part is really needed. I guess I'll have to try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.