[DF] Test using the RDF's VariationFor and RunGraphs for DistRDF too #980
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
Starting build on |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| from DistRDF.Backends import Dask | ||
|
|
||
| VariationsFor = ROOT.RDF.Experimental.VariationsFor | ||
|
|
||
| class TestVariations: |
There was a problem hiding this comment.
E302: expected 2 blank lines, found 1
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
|
||
| def test_histo(self, connection): | ||
| df = Spark.RDataFrame(10, sparkcontext=connection, npartitions=2).Define("x", "1") | ||
| df1 = df.Vary("x", "ROOT::RVecI{-2,2}", ["down", "up"]) | ||
| h = df1.Histo1D(("name", "title", 10, -10, 10), "x") | ||
| histos = DistRDF.VariationsFor(h) | ||
| histos = VariationsFor(h) |
There was a problem hiding this comment.
reportUndefinedVariable: "VariationsFor" is not defined
❗❗ 4 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| python/distrdf/spark/check_variations.py | 29 |
| python/distrdf/spark/check_variations.py | 44 |
| python/distrdf/spark/check_variations.py | 60 |
| python/distrdf/spark/check_variations.py | 77 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
Build failed on ROOT-debian10-i386/soversion. |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on mac11/noimt. Errors:
|
|
Build failed on mac12arm/cxx20. Failing tests: |
eguiraud
force-pushed
the
df-distrdf-uniform-api
branch
from
339825a to
c4ba60d
Compare
|
Starting build on |
| from DistRDF.Backends import Spark | ||
|
|
||
| VariationsFor = ROOT.RDF.Experimental.VariationsFor | ||
|
|
||
| class TestVariations: |
There was a problem hiding this comment.
E302: expected 2 blank lines, found 1
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. |
|
Build failed on mac11/noimt. Failing tests: |
|
Build failed on mac12arm/cxx20. Failing tests: |
Needs root-project/root#13248 .