Button indeterminate #55
Conversation
|
ahhh which ticket is this code for? As per the ticket this is for an "Icon Button" atom not a "Circular Indeterminate float button" Ok so I see whats happening now :) |
There was a problem hiding this comment.
Ok so I don't think you understood what this ticket was about - reading the tickets now I am not surprised. I think we needed to talk about it more before you started so you had a chance to ask about its scope.
anyway the point was to add a spinner state for when the button had been clicked and it was waiting to do something.
yo can see by the snippet I added to this pr that this is just a case of swapping out the child component (text or icon) for a spinner.
| const A016 = props => { | ||
| const { text, classes } = props | ||
| return ( | ||
| <Fragment> |
There was a problem hiding this comment.
so I pulled the code and wrote this:
<Button variant='contained' disabled={submitting}>
{submitting ? (
<CircularProgress size={22} />
) : (
<Icon iconname={iconname} />
)}
</Button>
| // List of stories of use cases for atom | ||
| storiesOf('Atoms|A016 - Circular Indeterminate button', module) | ||
| .add('Participate Order Button', () => ( | ||
| <Button text={'Participate Order'} color={'default'} /> |
There was a problem hiding this comment.
and this
() => <Button iconname='add' submitting />
|
also the spinner state you added to the floating button should just go on A002 |
initial code button indeterminate state