Skip to content

fix: no space after left parenthesis #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maelle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: no space after left parenthesis #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/unleash.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ handle_text <- function(text) {
next_sibling <- xml2::xml_find_all(text, "following-sibling::*[1]")
if (length(next_sibling) > 0 && xml2::xml_name(next_sibling) == "link") {
end_space <- endsWith(xml2::xml_text(text), " ")
if (!end_space) {
end_left_parenthesis <- endsWith(xml2::xml_text(text), "(")
if (!end_space && !end_left_parenthesis) {
xml2::xml_text(text) <- paste0(xml2::xml_text(text), " ")
}
}
Expand Down
4 changes: 3 additions & 1 deletion inst/example.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ This is a footnote [^ok].

[^ok]: Some more information.

R has well-developed plotting capabilities, and the `ggplot2` package is one of, if not the most powerful pieces of plotting software available today!!! We will begin learning to use `ggplot2` in the next episode.
R has well-developed plotting capabilities, and the `ggplot2` package is one of, if not the most powerful pieces of plotting software available today!!! We will begin learning to use `ggplot2` in the next episode.

This is a link in parentheses ([example](https://example.com)).
2 changes: 2 additions & 0 deletions tests/testthat/_snaps/unleash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@
[29] ""
[30] "R has well-developed plotting capabilities, and the `ggplot2` package is one of, if not the most powerful pieces of plotting software available today!!!"
[31] "We will begin learning to use `ggplot2` in the next episode."
[32] ""
[33] "This is a link in parentheses ([example](https://example.com))."

Loading