Skip to content

Refactor/rt pub define #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

firesurfer
Copy link
Contributor

This is a followup PR for #210

The approach in general probably needs some discussion. But I think it is a first step into removing conditional compilation based on a define set in a different file.

This implementation keeps the ability to select the polling mode via the define but prints a deprecation message.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (1ce4df7) to head (94e0298).

Files with missing lines Patch % Lines
include/realtime_tools/realtime_publisher.hpp 98.63% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   72.72%   75.00%   +2.27%     
==========================================
  Files           7        7              
  Lines         429      468      +39     
  Branches       71       78       +7     
==========================================
+ Hits          312      351      +39     
  Misses         73       73              
  Partials       44       44              
Flag Coverage Δ
unittests 75.00% <98.63%> (+2.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_publisher.hpp 97.70% <98.63%> (+1.86%) ⬆️

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
Copy link

mergify bot commented Mar 31, 2025

This pull request is in conflict. Could you fix it @firesurfer?

@github-actions github-actions bot removed the stale label Apr 1, 2025
@christophfroehlich
Copy link
Contributor

@firesurfer do you have capacity right now to finish this PR? We have a compile-time warning from the tests since #210, would be great to fix at least this one ;)
Have you by chance read #24 and #81? Not sure if the first one still applies, but the restructuring is still valid, right?

@firesurfer
Copy link
Contributor Author

@christophfroehlich I am currently very limited timewise (as you might have noticed)
This refactoring is only partially valid actually as we decided to remove the polling mode (as far as I remember).

My basic idea behind this refactoring was to provide an interface as similar as possible to the rclcpp::publisher.

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants