-
Notifications
You must be signed in to change notification settings - Fork 81
Refactor/rt pub define #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor/rt pub define #211
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 72.72% 75.00% +2.27%
==========================================
Files 7 7
Lines 429 468 +39
Branches 71 78 +7
==========================================
+ Hits 312 351 +39
Misses 73 73
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This pull request is in conflict. Could you fix it @firesurfer? |
@firesurfer do you have capacity right now to finish this PR? We have a compile-time warning from the tests since #210, would be great to fix at least this one ;) |
@christophfroehlich I am currently very limited timewise (as you might have noticed) My basic idea behind this refactoring was to provide an interface as similar as possible to the rclcpp::publisher. |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This is a followup PR for #210
The approach in general probably needs some discussion. But I think it is a first step into removing conditional compilation based on a define set in a different file.
This implementation keeps the ability to select the polling mode via the define but prints a deprecation message.