Correctly resolve symlinks to device paths #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flynneva
approved these changes
Feb 4, 2025
|
Oops it looks like unrelated to this PR I've broken CI so that the tests are not actually ran 😅 I'll test this locally and fix CI when I have the chance, but overall this looks good. Thanks 🙏 |
|
wait i didnt mean to close this, was just trying to rebase. sorry about that 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple cameras, it can be handy to set the video devices using the symlinks provided in
/dev/v4l/by-idor/dev/v4l/by-path, because the IDs in/dev/video<ID>may change after a reboot. However, the relative paths from these symlinks are currently just appended to /dev/ and thus falsely resolved to/dev/../../video<ID>.With this PR, symlinks located in another directory than /dev/ can be used for the video_device parameter.