Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Index to toc, remove Search link #118

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Apr 19, 2024

Fixes #117

Generally I'd like to remove items from the home page that are better accessed directly from the toc sidebar, this is one case of that. But in this case we are also adding something to the toc. Previously adding the index to the toc could only be done with a template, but from Sphinx 5.2 it is easily done.

The search link appears useless to me, search is accessed from the top of the sidebar.

@rkent rkent requested review from audrow and tfoote as code owners April 19, 2024 18:19
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@tfoote tfoote merged commit 3e03a08 into ros-infrastructure:main Apr 19, 2024
4 checks passed
@rkent rkent deleted the index-in-toc branch April 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include index in toc, not on home page
2 participants