Skip to content

Fix compilation and loading of shared libraries on Windows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berndpfrommer merged 2 commits into from
Jun 16, 2025
Merged

Fix compilation and loading of shared libraries on Windows #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
334009d
Fix compilation and running on Windows
traversaro Jun 14, 2025
484251e
retrigger checks
berndpfrommer Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apriltag_detector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
cmake_minimum_required(VERSION 3.16)
project(apriltag_detector)

add_compile_options(-Wall -Wextra -Wpedantic -Werror)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Werror)
endif()
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)

# find dependencies
find_package(ament_cmake REQUIRED)
Expand Down Expand Up @@ -81,8 +84,7 @@ ament_export_dependencies(sensor_msgs apriltag_msgs image_transport cv_bridge
install(TARGETS
${PROJECT_NAME}
${PROJECT_NAME}_component
EXPORT ${PROJECT_NAME}_export
DESTINATION lib)
EXPORT ${PROJECT_NAME}_export)

# the node must go into the project specific lib directory or else the launch
# file will not find it
Expand Down
8 changes: 5 additions & 3 deletions apriltag_detector_mit/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
cmake_minimum_required(VERSION 3.16)
project(apriltag_detector_mit)

add_compile_options(-Wall -Wextra -Wpedantic -Werror)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Werror)
endif()
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)

# find dependencies
find_package(ament_cmake REQUIRED)
Expand Down Expand Up @@ -62,8 +65,7 @@ ament_export_libraries(${PROJECT_NAME})

install(
TARGETS ${PROJECT_NAME}
EXPORT ${PROJECT_NAME}_export
DESTINATION lib)
EXPORT ${PROJECT_NAME}_export)

if(BUILD_TESTING)
find_package(ament_cmake REQUIRED)
Expand Down
8 changes: 5 additions & 3 deletions apriltag_detector_umich/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
cmake_minimum_required(VERSION 3.16)
project(apriltag_detector_umich)

add_compile_options(-Wall -Wextra -Wpedantic -Werror)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Werror)
endif()
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)

# find dependencies
find_package(ament_cmake REQUIRED)
Expand Down Expand Up @@ -64,8 +67,7 @@ ament_export_libraries(${PROJECT_NAME})

install(
TARGETS ${PROJECT_NAME}
EXPORT ${PROJECT_NAME}_export
DESTINATION lib)
EXPORT ${PROJECT_NAME}_export)

if(BUILD_TESTING)
find_package(ament_cmake REQUIRED)
Expand Down
6 changes: 4 additions & 2 deletions apriltag_draw/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
cmake_minimum_required(VERSION 3.16)
project(apriltag_draw)

add_compile_options(-Wall -Wextra -Wpedantic -Werror)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Werror)
endif()
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)

# find dependencies
find_package(ament_cmake REQUIRED)
Expand Down Expand Up @@ -83,7 +86,6 @@ install(TARGETS
install(
TARGETS ${PROJECT_NAME}
EXPORT ${PROJECT_NAME}_export
DESTINATION lib
)

install(
Expand Down
4 changes: 3 additions & 1 deletion apriltag_tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
cmake_minimum_required(VERSION 3.16)
project(apriltag_tools)

add_compile_options(-Wall -Wextra -Wpedantic -Werror)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Werror)
endif()

# find dependencies
find_package(ament_cmake REQUIRED)
Expand Down