fix bugs in SetCameraInfo functions #377
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the SetCameraInfo service fails for a couple of reasons.
Firstly the function signature for CameraInfoManager.setCameraInfo has changed from
def setCameraInfo(self, request):
to
def setCameraInfo(self, request, response):
Secondly
yaml.safe_dump
does not acceptarray.array
andnumpy.ndarray
which are both used internally by the CameraInfo message type.This pull request corrects both errors on rolling (may need backporting, but I'm not sure how to do that on github).
Best Wishes,
Phil