Remove lockfiles from being tracked #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <[email protected]>
|
The CI still seems to be failing even with the lockfile removed. Is this expected behavior? |
|
The CI for Rust Minimal and Rust Windows will continue to fail for all PRs until ros2-rust/rosidl_runtime_rs#13 is merged upstream. |
luca-della-vedova
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
I'm seeing CI failures on #492 precisely due to this lockfile issue, CI seems to be good here
jhdcs
approved these changes
Aug 6, 2025
|
Sorry for the delay. This looks good to me as well. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the working group meeting, once the lockfiles were committed, we wound up having a lot more unnecessary churn in the git history, and more crucially we started seeing breakages in the "Rust Minimal" CI due to new lockfiles being generated that are incompatible with Rust compiler version 1.75.
This PR reverts our practices by removing the lockfiles and putting
Cargo.lockback into the.gitignorelist.