PolygonInstance and PolygonInstanceStamped backported #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaciejGroszyk <[email protected]>
7 tasks
fujitatomoya
requested changes
Apr 3, 2025
There was a problem hiding this comment.
i would cherry-pick #232, instead of creating another PR to keep the fix traceable and consistent. a few things are broken from original fix.
Comment on lines
+28
to
+29
| "msg/PolygonInstance.msg" | ||
| "msg/PolygonInstanceStamped.msg" |
There was a problem hiding this comment.
README.md update is missing.
| # It includes a unique identification field for disambiguating multiple instances | ||
|
|
||
| geometry_msgs/Polygon polygon | ||
| int64 id |
There was a problem hiding this comment.
return code is missing at the end of the file.
|
Closing in favor of #277 🧇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I backported PolygonInstance and PolygonInstanceStamped from rolling to humble to fulfill requirements to finish a PR. ros-navigation/navigation2#5017