user control of log file base names, in ros2 launch #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
15bc3a0 to
6f17a51
Compare
Tanishq30052002
changed the title
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
2 times, most recently
from
f49281d to
6f17a51
Compare
|
@fujitatomoya can you please review this |
kscottz
reviewed
Apr 21, 2025
kscottz
reviewed
Apr 24, 2025
|
@Tanishq30052002 you've got one little flake8 issue left. I tried to fix it really quick. It might take a couple tries. Once that passes we're good to merge! Thanks for the help! |
If we squash the last 2 commits, one of mine and the other yours, I don't see any difference. |
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
6ba7407 to
dc84082
Compare
|
@kscottz linter error is resolved, i will drop those 2 extra commits |
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
dc84082 to
f41a532
Compare
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
b50e49d to
963b93e
Compare
fujitatomoya
approved these changes
Apr 28, 2025
|
Note This depends on ros2/launch#861 |
kscottz
approved these changes
Apr 28, 2025
Signed-off-by: Tanishq Chaudhary <[email protected]>
Signed-off-by: Tanishq Chaudhary <[email protected]>
Signed-off-by: Tanishq Chaudhary <[email protected]>
…e for log file name Signed-off-by: Tanishq Chaudhary <[email protected]>
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
222ffc7 to
888c941
Compare
Co-authored-by: Katherine Scott <[email protected]> Signed-off-by: Tanishq Chaudhary <[email protected]>
Tanishq30052002
force-pushed
the
user_control_for_log_files
branch
from
888c941 to
9e061c9
Compare
|
@fujitatomoya this looks like is good to go. |
depends on ros2/launch#861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #380
Depend: ros2/launch#861