Add missing 's' to 'NodeParametersInterface' in doc/comment #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
|
We could backport this to Kilted like #2822 |
ahcorde
approved these changes
Apr 30, 2025
|
Let's see if the Rpr job passes. If it does, then we could just skip ci.ros2.org |
|
The Rpr job did pass, so I'll merge this. |
christophebedard
deleted the
christophebedard/node-parameters-interface-typo
branch
|
@Mergifyio backport kilted |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Signed-off-by: Christophe Bedard <[email protected]> (cherry picked from commit b1ec85d)
There was a problem hiding this comment.
@christophebedard sorry my bad, and thanks for fixing this 🙇
|
No worries, at least my finding-tiny-typos superpower is useful sometimes 😆 |
christophebedard
added a commit
that referenced
this pull request
Apr 30, 2025
…2833) (cherry picked from commit b1ec85d) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2822.