Skip to content

Conversation

@baszalmstra
Copy link

As far as I understand this package does not expose an build time interface that requires amend_cmake so the buildtool_export_depend is not needed.

As far as I understand this package does not expose an build time interface that requires `amend_cmake` so the `buildtool_export_depend` is not needed.

Signed-off-by: Bas Zalmstra <[email protected]>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this makes sense, unless this package provides macros or CMake functions that other downstream packages should use in their build process.

i would like to another review on this before CI/merge.

@lobolanja
Copy link
Collaborator

@fgallegosalido can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants