Skip to content

Move comment to the right code line in code-block #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

christophebedard
Copy link
Member

Follow-up to #5322, see #5322 (comment)

This was originally:

.. code-block:: console

    # Make a virtual env and activate it
    virtualenv -p python3 ./venv
    source ./venv/bin/activate
    # Make sure that colcon does not try to build the venv
    touch ./venv/COLCON_IGNORE

So the second comment belongs to the last line, not the second line.

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Apr 28, 2025
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14715375396/artifacts/3024413274.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5400/index.html in your favorite browser

@ahcorde ahcorde merged commit a1c7310 into rolling Apr 28, 2025
5 checks passed
@ahcorde ahcorde deleted the christophebedard/move-comment-to-correct-code-line branch April 28, 2025 20:34
mergify bot pushed a commit that referenced this pull request Apr 28, 2025
Signed-off-by: Christophe Bedard <[email protected]>
(cherry picked from commit a1c7310)
mergify bot pushed a commit that referenced this pull request Apr 28, 2025
Signed-off-by: Christophe Bedard <[email protected]>
(cherry picked from commit a1c7310)
mergify bot pushed a commit that referenced this pull request Apr 28, 2025
Signed-off-by: Christophe Bedard <[email protected]>
(cherry picked from commit a1c7310)
ahcorde pushed a commit that referenced this pull request Apr 28, 2025
(cherry picked from commit a1c7310)

Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
ahcorde pushed a commit that referenced this pull request Apr 28, 2025
(cherry picked from commit a1c7310)

Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
ahcorde pushed a commit that referenced this pull request Apr 28, 2025
(cherry picked from commit a1c7310)

Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants