add "--param-type" option to ros2param list. #572
Conversation
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
A few things to change in here, but I like the idea.
|
could you check once again? |
Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
Use a map so we don't have to continually do a search in the inner loop. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
topic-20201028-print-param-type
branch
from
6d077e3 to
174dd2f
Compare
|
@fujitatomoya FYI, I rebased this code and did a few more fixups to make the type lookup even faster. |
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
One thing that would be really nice to do here would be to add some "cli" tests for the list verb, like we have for dump in https://github.com/ros2/ros2cli/blob/master/ros2param/test/test_verb_dump.py . I don't think it would be too hard to add, and would give us a bit more verification of this work. @fujitatomoya do you have some time to look into that?
Never mind. I missed that we had #389 already open, and apparently it is harder than I think since we never solved it there. I'm going to approve this and run CI on it. |
|
CI:
|
|
@claireyywang @mabelzhang I'd appreciate a second look here since I did some of the modifications myself. |
|
All right, we have approvals, green CI. I'm going to go ahead and merge, thanks @fujitatomoya ! |
thanks 👍 this is better! |
3 participants
address #569
Signed-off-by: Tomoya.Fujita [email protected]