Static typing for Message, Services, and Actions

[InvincibleRMC]

Adds static typing to generated messages. Closes #157.

[InvincibleRMC]

Still need to fix a circular import issue.

[InvincibleRMC]

Now that kilted is starting to wrap up friendly ping @sloretz to re-review when you get a chance.

[InvincibleRMC]

Friendly ping @sloretz to finish the review when you get a chance.

[ros-discourse]

This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there:

https://discourse.ros.org/t/python-generated-messages-with-static-type-hints/45156/1

[InvincibleRMC]

@benjaminwp18 Thanks so much for the review! I have addressed your feedback. Please let me know if you have any other feedback.

[InvincibleRMC]

@christophebedard when you get a chance I would appreciate a ROS Maintainer review as well.

[christophebedard]

Pulls: #206
Gist: https://gist.githubusercontent.com/christophebedard/9a392164fa167b98f745f9a505a40a73/raw/1cb2fe9a7ed734bbd4a459211613e40209a97991/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16562

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[christophebedard]

I ran full CI^ so that interfaces get generated, and so that hopefully the linters (including mypy) run on the generated files as part of tests in the various interface packages. The Rpr job doesn't really test much here.

[InvincibleRMC]

Thanks so much for the review!

I ran full CI^ so that interfaces get generated, and so that hopefully the linters (including mypy) run on the generated files as part of tests in the various interface packages. The Rpr job doesn't really test much here.

I was going to ask about this since I have a feeling this will expose some downstream bugs to be fixed.

[christophebedard]

Pulls: #206
Gist: https://gist.githubusercontent.com/christophebedard/23340b5f0c0b1e577396c407ded46165/raw/1cb2fe9a7ed734bbd4a459211613e40209a97991/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16581

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

Another old mypy bug.

import typing

class A:

    def __init__(self) -> typing.NoReturn:   # The return type of "__init__" must be None
        raise NotImplementedError()

Will add a # type: ignore for now. Cannot wait for rhel 10.