Fix Ogre build failure on Xcode 26 (xcodebuild -n removed)#1751
Open
idesign0 wants to merge 3 commits into
Open
Fix Ogre build failure on Xcode 26 (xcodebuild -n removed)#1751idesign0 wants to merge 3 commits into
idesign0 wants to merge 3 commits into
Conversation
Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
Contributor
Thanks for the mention! Indeed, that may be the case, fyi @wep21 @Tobias-Fischer. |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Xcode 26 removed the
-nflag fromxcodebuild. Ogre v1.12.10's CMakeLists.txt usesexecute_processwith a shell pipe to detect the macOS SDK path:CMake's
execute_processdoes not use a shell, so| head -n 1is passed as literal arguments toxcodebuild. With Xcode 26, the-nargument is rejected:The full usage page is captured into
CMAKE_OSX_SYSROOT, corrupting it with embedded newlines and breaking all subsequent compiler invocations:Fix
Add
patches/0007-fix-xcodebuild-n-xcode26.patchwhich replaces the broken call with:xcrun --show-sdk-pathis the correct modern replacement and works across all supported Xcode versions.Fyi, @traversaro — this may affect RoboStack/conda-forge builds of rviz on macOS with Xcode 26. The same bug exists in gz_ogre_next_vendor (ogre-next v2.3.3, same execute_process pipe pattern) — fix incoming there too.