fix: use Id component for txId display in watcher actions (#9)#17
Open
odiseusme wants to merge 1 commit intorosen-bridge:devfrom
Open
fix: use Id component for txId display in watcher actions (#9)#17odiseusme wants to merge 1 commit intorosen-bridge:devfrom
odiseusme wants to merge 1 commit intorosen-bridge:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@odiseusme is attempting to deploy a commit to the rosen-bridge Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Changes
Replaces raw
{response.txId}text wrapped in<Link>with the<Id>component across all 3 watcher action forms (lock, unlock, withdraw).What this does:
...+ last 8 characters) using<Id indicator="middle">getTxURL(NETWORKS.ergo.key, response.txId)passed ashrefto<Id>target="_blank"andrel="noopener noreferrer"are handled internally by the<Id>componentPer-file changes:
Idimport, removed unusedLinkimport, replaced<Link>with<Id>next/linkimport, addedIdto ui-kit import, replaced<Link>with<Id>Linkimport (Idwas already imported), replaced<Link>with<Id>Notes:
?? '/'and?? ''fallbacks ongetTxURL()in unlock and withdraw — theIdcomponent'shrefis optional, soundefinedgracefully renders plain text without a broken link<Id indicator="middle">pattern already used inwithdraw/page.tsxfor token IDs