Initial Handshake Implementation#7
Open
AcoSmrkas wants to merge 6 commits intorosen-bridge:devfrom
Open
Conversation
RaaCT0R
requested changes
Apr 23, 2026
Comment on lines
+160
to
+162
| handshakeScanner: | ||
| warnDifference: 2 # warning difference between existing and scanned blocks height | ||
| criticalDifference: 10 # critical difference between existing and scanned blocks height |
Member
There was a problem hiding this comment.
🚫 Required Change
Please remove these configs.
| 'observation.confirmation' | ||
| ); | ||
| const blockTime = { | ||
| const blockTimeByNetwork: Record<NetworkType, number> = { |
Member
There was a problem hiding this comment.
🚫 Required Change
Revert this change (please avoid unnecessary changes). Adding the new record is sufficient here.
Comment on lines
+737
to
+738
| handshakeScannerWarnDiff: number; | ||
| handshakeScannerCriticalDiff: number; |
Member
There was a problem hiding this comment.
🚫 Required Change
Please remove these 2 variables.
Comment on lines
+223
to
+224
| let scannerWarnDiff = currentConfig.healthCheck.scannerWarnDiff; | ||
| let scannerCriticalDiff = currentConfig.healthCheck.scannerCriticalDiff; |
Member
There was a problem hiding this comment.
🚫 Required Change
Please remove these two.
Comment on lines
+193
to
+196
| await CreateScanner.instance.createHandshakeScanner( | ||
| handshakeConfig, | ||
| rosenConfig | ||
| ); |
Member
There was a problem hiding this comment.
🚫 Required Change
Please pass config.observationStoreRawData to it:
Suggested change
| await CreateScanner.instance.createHandshakeScanner( | |
| handshakeConfig, | |
| rosenConfig | |
| ); | |
| await CreateScanner.instance.createHandshakeScanner( | |
| handshakeConfig, | |
| rosenConfig, | |
| config.observationStoreRawData | |
| ); |
Comment on lines
+632
to
+648
| rosenConfig: RosenConfig | ||
| ) => { | ||
| if (!this.observationScanner) { | ||
| if (handshakeConfig.rpc) { | ||
| this.observationScanner = new HandshakeRpcScanner({ | ||
| dataSource, | ||
| initialHeight: handshakeConfig.initialHeight, | ||
| network: createHandshakeRpcNetworkConnectorManager(), | ||
| logger: loggers.observationScannerLogger, | ||
| }); | ||
|
|
||
| const observationExtractor = new HandshakeRpcObservationExtractor( | ||
| rosenConfig.lockAddress, | ||
| dataSource, | ||
| TokensConfig.getInstance().getTokenMap(), | ||
| loggers.observationExtractorLogger | ||
| ); |
Member
There was a problem hiding this comment.
🚫 Required Change
Following my previous comment, please add it here too.
Suggested change
| rosenConfig: RosenConfig | |
| ) => { | |
| if (!this.observationScanner) { | |
| if (handshakeConfig.rpc) { | |
| this.observationScanner = new HandshakeRpcScanner({ | |
| dataSource, | |
| initialHeight: handshakeConfig.initialHeight, | |
| network: createHandshakeRpcNetworkConnectorManager(), | |
| logger: loggers.observationScannerLogger, | |
| }); | |
| const observationExtractor = new HandshakeRpcObservationExtractor( | |
| rosenConfig.lockAddress, | |
| dataSource, | |
| TokensConfig.getInstance().getTokenMap(), | |
| loggers.observationExtractorLogger | |
| ); | |
| rosenConfig: RosenConfig, | |
| observationStoreRawData: boolean | |
| ) => { | |
| if (!this.observationScanner) { | |
| if (handshakeConfig.rpc) { | |
| this.observationScanner = new HandshakeRpcScanner({ | |
| dataSource, | |
| initialHeight: handshakeConfig.initialHeight, | |
| network: createHandshakeRpcNetworkConnectorManager(), | |
| logger: loggers.observationScannerLogger, | |
| }); | |
| const observationExtractor = new HandshakeRpcObservationExtractor( | |
| rosenConfig.lockAddress, | |
| dataSource, | |
| TokensConfig.getInstance().getTokenMap(), | |
| loggers.observationExtractorLogger, | |
| observationStoreRawData | |
| ); |
| @@ -1,3 +1,4 @@ | |||
| src/config/*.json | |||
Member
There was a problem hiding this comment.
🚫 Required Change
Please revert this change.
Comment on lines
+34
to
+35
| import { HandshakeRpcObservationExtractor } from '@rosen-bridge/handshake-observation-extractor'; | ||
| import { HandshakeRpcScanner } from '@rosen-bridge/handshake-scanner'; |
Member
There was a problem hiding this comment.
🚫 Required Change
Seems you've forgot to install these two packages (they should be included in package.json file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation following RCS-003 - https://github.com/rosen-bridge/rcs/tree/master/rcs-003