fix: Restore search-based automation after rossoctl rename - #33
Merged
rubambiza merged 1 commit intoJul 27, 2026
Merged
Conversation
GitHub issue/PR search does not follow org renames, so three search-backed code paths silently broke when kagenti became rossoctl (git and gh api calls kept working via redirect): - pr-review-impact.sh get_repos(): reviewed-by search 422'd on the old repo names, freezing impact metrics at reviewed=0. Emit rossoctl/* with name remaps (kagenti->rossoctl, kagenti-extensions->cortex). - extract-broken-links.sh: internal/external classifier matched only github.com/kagenti. Match both orgs so surviving (redirecting) old links stay internal; drop kagenti after a docs sweep. - link-health-scanner.sh: org:kagenti broken-link issue search 422'd, zeroing the dashboard's per-repo issue counts. Use org:rossoctl. Add a rossoctl internal-link test case. Verified end-to-end: impact reviewed count restored to 36, org:rossoctl issue search returns results where org:kagenti 422s. Part of rossoctl#32. Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
rubambiza
added
the
ready-for-ai-review
clawgenti
reviewed
Jul 23, 2026
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Multi-file fix restoring three search-backed code paths broken by the kagenti→rossoctl org rename: pr-review-impact.sh repo list, extract-broken-links.sh internal-category regex (now matches both orgs for redirect continuity), and link-health-scanner.sh org-wide issue search. New test case 6b validates the rossoctl internal-link classification.
All checks pass. Ready for human review.
Reviewed by clawgenti using github:pr-review
rubambiza
added
ready-for-human-review
esnible
approved these changes
Jul 27, 2026
4 tasks
rubambiza
added a commit
that referenced
this pull request
Jul 28, 2026
Rewire the two PR-review programs to derive their repo set from the shared core-repos allowlist via get_core_repos(), replacing the hardcoded 4-repo lists (which #33/#34 had corrected to rossoctl names but still duplicated in each script). - pr-review-scanner.sh: build REPOS from get_core_repos() with a portable while-read loop (mapfile is bash 4+, absent on macOS 3.2); fail loud on an empty/unloadable allowlist. - pr-review-impact.sh: get_repos() delegates to get_core_repos(); update the FUTURE SEAM comment to reference the allowlist + rossoctl org. - program-lib.sh: fix the helper usage examples to the portable idiom (no mapfile). Coverage expands from 4 to the 8 core repos, both programs now sharing one source of truth. Verified on bash 3.2: fail-loud path fires, success loads 8 repos; full test suite passes. Part of #29 (epic #32). Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub issue/PR search does not follow org renames, so three search-backed code paths silently broke when
kagentibecamerossoctl(git andgh apicalls kept working via redirect, which is why this went unnoticed):pr-review-impact.shget_repos()— thereviewed-bysearch 422'd on the old repo names, so the script wrotereviewed: 0and the impact metrics froze. Now emitsrossoctl/*with the name remaps (kagenti→rossoctl,kagenti-extensions→cortex).extract-broken-links.sh— the internal/external classifier matched onlygithub.com/kagenti, so links under the new org were misclassified as external and stopped getting fix-PRs. Now matches both orgs ((kagenti|rossoctl)) so surviving (still-redirecting) old links stay internal; thekagentialternative can be dropped after a docs sweep.link-health-scanner.sh— the org-wide broken-link issue search usedorg:kagenti, which 422'd and zeroed the dashboard's per-repo issue counts. Now usesorg:rossoctl.Scoped to the functional restore only — no cleanup of the remaining (redirect-working)
kagentireferences, which are tracked separately.Verification
test-extract-broken-links.sh24/24, plustest-pr-review-impact.sh,test-pr-review-integration.sh,test-parse-diff-map.sh).pr-review-impact.shreviewed count restored from 0 to a live nonzero value with all activations detected; theorg:rossoctlissue search returns results whereorg:kagenti422s; agithub.com/rossoctl/...link classifies as internal.Part of #32. Fixes #28.
Assisted-By: Claude Code