Skip to content

feat: add gpt-5.4-mini codex model definitions #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WormW wants to merge 1 commit into from
+70 −1
Closed

feat: add gpt-5.4-mini codex model definitions #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 70 additions & 1 deletion internal/registry/models/models.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,6 +1601,29 @@
]
}
},
{
"id": "gpt-5.4-mini",
"object": "model",
"created": 1772668800,
"owned_by": "openai",
"type": "openai",
"display_name": "GPT 5.4 Mini",
"version": "gpt-5.4-mini",
"description": "Stable version of GPT 5.4 Mini",
"context_length": 1050000,
"max_completion_tokens": 128000,
"supported_parameters": [
"tools"
],
"thinking": {
"levels": [
"low",
"medium",
"high",
"xhigh"
]
}
Comment on lines +1605 to +1625
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This new JSON object for gpt-5.4-mini is syntactically incorrect as it's missing commas between the key-value pairs. This will cause JSON parsing to fail.

While fixing this, please also consider making the description more informative. To help users, you could clarify what 'Mini' implies (e.g., faster, more cost-effective) compared to the base gpt-5.4 model.

This feedback applies to all three locations where this model definition is added.

      "id": "gpt-5.4-mini",
      "object": "model",
      "created": 1772668800,
      "owned_by": "openai",
      "type": "openai",
      "display_name": "GPT 5.4 Mini",
      "version": "gpt-5.4-mini",
      "description": "Stable version of GPT 5.4 Mini, a faster and more cost-effective variant of GPT 5.4.",
      "context_length": 1050000,
      "max_completion_tokens": 128000,
      "supported_parameters": [
        "tools"
      ],
      "thinking": {
        "levels": [
          "low",
          "medium",
          "high",
          "xhigh"
        ]
      }

},
{
"id": "gpt-5.4",
"object": "model",
Expand Down Expand Up @@ -1876,6 +1899,29 @@
]
}
},
{
"id": "gpt-5.4-mini",
"object": "model",
"created": 1772668800,
"owned_by": "openai",
"type": "openai",
"display_name": "GPT 5.4 Mini",
"version": "gpt-5.4-mini",
"description": "Stable version of GPT 5.4 Mini",
"context_length": 1050000,
"max_completion_tokens": 128000,
"supported_parameters": [
"tools"
],
"thinking": {
"levels": [
"low",
"medium",
"high",
"xhigh"
]
}
Comment on lines +1903 to +1923
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the other additions, this JSON object is missing commas between key-value pairs, which will break JSON parsing. Please also consider improving the description for better clarity as suggested previously.

      "id": "gpt-5.4-mini",
      "object": "model",
      "created": 1772668800,
      "owned_by": "openai",
      "type": "openai",
      "display_name": "GPT 5.4 Mini",
      "version": "gpt-5.4-mini",
      "description": "Stable version of GPT 5.4 Mini, a faster and more cost-effective variant of GPT 5.4.",
      "context_length": 1050000,
      "max_completion_tokens": 128000,
      "supported_parameters": [
        "tools"
      ],
      "thinking": {
        "levels": [
          "low",
          "medium",
          "high",
          "xhigh"
        ]
      }

},
{
"id": "gpt-5.4",
"object": "model",
Expand Down Expand Up @@ -2151,6 +2197,29 @@
]
}
},
{
"id": "gpt-5.4-mini",
"object": "model",
"created": 1772668800,
"owned_by": "openai",
"type": "openai",
"display_name": "GPT 5.4 Mini",
"version": "gpt-5.4-mini",
"description": "Stable version of GPT 5.4 Mini",
"context_length": 1050000,
"max_completion_tokens": 128000,
"supported_parameters": [
"tools"
],
"thinking": {
"levels": [
"low",
"medium",
"high",
"xhigh"
]
}
Comment on lines +2201 to +2221
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the other additions, this JSON object is missing commas between key-value pairs, which will break JSON parsing. Please also consider improving the description for better clarity as suggested previously.

      "id": "gpt-5.4-mini",
      "object": "model",
      "created": 1772668800,
      "owned_by": "openai",
      "type": "openai",
      "display_name": "GPT 5.4 Mini",
      "version": "gpt-5.4-mini",
      "description": "Stable version of GPT 5.4 Mini, a faster and more cost-effective variant of GPT 5.4.",
      "context_length": 1050000,
      "max_completion_tokens": 128000,
      "supported_parameters": [
        "tools"
      ],
      "thinking": {
        "levels": [
          "low",
          "medium",
          "high",
          "xhigh"
        ]
      }

},
{
"id": "gpt-5.4",
"object": "model",
Expand Down Expand Up @@ -2680,4 +2749,4 @@
"max_completion_tokens": 32768
}
]
}
}
Loading