fix: Don't crash on Android if data source throws Exception

See immich-app/immich#15230 (comment). So far, only java.lang.Error was caught, but HttpDataSource.InvalidResponseCodeException is a java.lang.Exception.
rovo89 · Jan 10, 2025 · d381db6 · d381db6
1 parent ac78487
commit d381db6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/android/src/main/kotlin/me/albemala/native_video_player/NativeVideoPlayerViewController.kt b/android/src/main/kotlin/me/albemala/native_video_player/NativeVideoPlayerViewController.kt
@@ -134,7 +134,7 @@ class NativeVideoPlayerViewController(
         if (error.cause == null) {
             api.onError(Error("Unknown playback error occurred"))
         } else {
-            api.onError(error.cause as Error)
+            api.onError(error.cause as Throwable)
         }
     }
 }
diff --git a/...rc/main/kotlin/me/albemala/native_video_player/platform_interface/NativeVideoPlayerApi.kt b/...rc/main/kotlin/me/albemala/native_video_player/platform_interface/NativeVideoPlayerApi.kt
@@ -48,7 +48,7 @@ class NativeVideoPlayerApi(
         channel.invokeMethod("onPlaybackEnded", null)
     }
 
-    fun onError(error: Error) {
+    fun onError(error: Throwable) {
         channel.invokeMethod("onError", error.message)
     }