Reset core 1 when initializing flash algo #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Marked as draft as it may not be valid for rp2350) |
|
While this seems to work reliably, it solves the same issue as probe-rs/probe-rs#3429 Are there other users of flash-algo that might still need a manual reset of core 1? |
|
Sorry, misclicked the ready for review button :( |
|
There is a world in which you might want to not reset everything, but you want to change flash with both cores halted (emulated breakpoints comes to mind), but I think that wouldn't work with the flash algo as-is, and we should wait until we have someone that needs that first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug probes usually only do a sysreset before flashing a new firmware. But on rp2040, that only resets core 0, while core 1 might continue running. Depending on the firmware, this may interfere with the flashing. (Often, core 1 will just crash when the flash gets detached from XIP, but that's not guaranteed.)
So before starting the flash algorithm, make sure that core 1 is reset as well.