ASM integration in TypesLoaderVisitor #86
Conversation
| } | ||
| } | ||
|
|
||
| public Boolean isAnonymous() { |
There was a problem hiding this comment.
Primitive return instead of wrapper?
| return actualName; | ||
| } | ||
|
|
||
| public Boolean isPrivate() { |
| if (!actualName.contains(File.separator)){ | ||
| return null; | ||
| } | ||
| return getActualName().substring(0, getActualName().lastIndexOf(File.separator) + 1) |
There was a problem hiding this comment.
Really file separator? Or internal class name with "/"?
| } | ||
|
|
||
| outputStream.flush(); | ||
| byte[] var5 = outputStream.toByteArray(); |
src/main/java/org/walkmod/javalang/compiler/types/TypesLoaderVisitor.java
Show resolved
Hide resolved
| if (!actualName.contains(File.separator)){ | ||
| return null; | ||
| } | ||
| return getActualName().substring(0, getActualName().lastIndexOf("/") + 1) |
There was a problem hiding this comment.
internal name is "/" based. File.separator is wrong here.
| } | ||
|
|
||
| public String getSimpleName() { | ||
| int index = getActualName().lastIndexOf(File.separator); |
|
|
||
| public String getCanonicalName() { | ||
| return getPackage() + "." + getSimpleName().replaceAll("$", "\\."); | ||
| } |
There was a problem hiding this comment.
I do not agree. I may have multiple nesting levels, right?
There was a problem hiding this comment.
We had the same discussion 2 (?) years ago. :-)
"replace(a,b)" replaces all strings "a" with string "b".
replaceAll(regular-expression, replacement) replaces all occurences of the regular expression. And the regexp "$" means "end of line".
This patch replaces reflection by ASM and increases the performace almost a 20%. ASM parses binary files and allows to extract the minimum amount of information that is required to analyze.
This patch replaces reflection by ASM and increases the performace almost a 20%. ASM parses binary files and allows to extract the minimum amount of information that is required to analyze.
|
requests addressed |
|
ping @cal101 |
|
Moin Raquel! How are you! |
|
@rpau remember that you have a pending review request |
This patch replaces reflection by ASM and increases
the performace almost a 20%. ASM parses binary files and
allows to extract the minimum amount of information that
is required to analyze.