Conversation
Contributor
Author
|
@leafaar is it cool to add the changelog for the parallel encoding here or the changelog must accompany its corresponding commit |
There was a problem hiding this comment.
Pull request overview
This PR adds Unix domain socket (UDS) support for the gRPC listener, allowing clients to connect via unix:// addresses in addition to TCP addresses.
Changes:
- Introduced
GrpcAddressenum to support both TCP and Unix domain socket addresses - Modified gRPC server initialization to handle both TCP and UDS connection types
- Added warning when TLS is configured with Unix domain sockets
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| yellowstone-grpc-geyser/src/config.rs | Adds GrpcAddress enum with TCP/Unix variants and custom deserialization for unix:// prefix |
| yellowstone-grpc-geyser/src/grpc.rs | Updates server binding logic to create appropriate listener based on address type and handle socket cleanup |
| CHANGELOG.md | Documents the new Unix domain socket feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #STR-314