Add Docker smoke test to Docker Build Check workflow#105
Open
rroy676 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/health.Description
stationarr:smoke-testwithpush: false,load: true, and the build argAPP_VERSION=smoke-testso the image is local-only and versioned for testing.stationarr-smoke-testwithdocker run -d --name stationarr-smoke-test -p 3000:3000 stationarr:smoke-testand retriescurlagainst/api/healthfor up to 30 seconds."ok":true, print the health response to logs, dump container logs on timeout/failure, and always stop/remove the test container withdocker rm -f stationarr-smoke-testin anif: always()cleanup step.Testing
ruby -e "require 'yaml'; YAML.load_file('.github/workflows/docker-build-check.yml'); puts 'YAML OK'", which succeeded.git diff --checkto validate whitespace/format issues, which reported no problems.docker build --build-arg APP_VERSION=smoke-test -t stationarr:smoke-test .but the Docker CLI is not available in this environment, so a local image build was not executed here (the smoke test will run in CI where Docker is available).Codex Task