Draft
Conversation
Author
|
@hkwang could you review this pull request |
Contributor
|
Contributor
|
it just occurred to me that this is probably not the most recent version of the extrapolator since handling of the intensities does not seem to be described! I was editing the manuscript and going to add how we create normalized structure factor amplitudes. |
Contributor
|
Hopefully we can resolve the merge conflicts later. To reply to Doeke's point ii about refactoring main, extrapolate.py main() can be rewritten to look like this file: |
Contributor
|
yes, like that! |
Addressed previous edits: - Replaced the local function mean_intensity_by_resolution() with a call to reciprocalspaceship's equivalent function in scale_merged_intensities.py - Refactored main() so the default just calls a function extrapolate_dw() - Added NLL calculations that are outputted along with the extrapolated .mtz - Added a -default_scan flag that performs a 1D scan over p, holding r = 0.9
Author
|
@hkwang @DHekstra, the updated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of the double-Wilson Extrapolator that allows for parallel processing and handling of datasets for multiple common scaling+merging softwares.