Skip to content
Open
Show file tree
Hide file tree
Changes from 108 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d7925b0
Resolved merge conflicts
rsarwad Aug 4, 2022
4774eee
Merge branch '11191_move_ue_context' of https://github.com/rsarwad/ma…
rsarwad Aug 4, 2022
ffc179e
Modified code to convert C structure to protobuf structure for enb co…
rsarwad Aug 24, 2022
75e9e29
Resolved merge conflicts
rsarwad Sep 2, 2022
4a17193
Resolved merge conflicts
rsarwad Sep 6, 2022
3844c8b
Resolved merge conflicts
rsarwad Sep 8, 2022
26a3465
Addressed self review comments
rsarwad Sep 9, 2022
b27f5a8
docs: headlines in src/go/README.md are displayed correctly (#13972)
mpfirrmann Sep 20, 2022
ef36de1
fix(agw): Modified code to replace C structure ue_description_t to pr…
rsarwad Sep 21, 2022
b932d85
Resolved merge conflicts
rsarwad Sep 21, 2022
c3c289e
fix(nms): improve sync of orc8r tenants with NMS organizations in NMS…
alexzurbonsen Sep 21, 2022
7b3b3e7
fix(amf): Support for 5GS network feature support (#13413)
priya-wavelabs Sep 21, 2022
9a62811
Addressed self review comments
rsarwad Sep 21, 2022
d5379d2
fix(agw): c++ migration of nas files (#13904)
pruthvihebbani Sep 21, 2022
baf3bc7
chore: Publish environment logging for the Bazel integration tests (#…
vktng Sep 21, 2022
3da3b2f
fix: magma_deb integ tests can use config_iface_for_ipv6.py script (#…
nstng Sep 21, 2022
13139a0
docs(agw): Updated AGW Install docs for the 1.8.0 Release (#13926)
ShubhamTatvamasi Sep 22, 2022
1bfffb2
chore(ci): putting the RHEL8 certificates/entitlements in cleaner way…
rdefosse Sep 22, 2022
c825e1e
fix(nms): Display correct axios errors (#13986)
voisey Sep 22, 2022
c1c2778
fix(ci): Mitigate LSAN errors in LTE integ tests (#13940)
LKreutzer Sep 22, 2022
490c962
chore: lte integ tests always publish logs (#13991)
nstng Sep 23, 2022
f951954
chore: Fix scripts for Bazel integration tests (#13978)
vktng Sep 23, 2022
64f1b7c
fix(agw): Updated AGW Install script branch to v1.8 (#13996)
ShubhamTatvamasi Sep 23, 2022
f958ff5
fix: trf server logging is enabled again (#13990)
nstng Sep 23, 2022
2ab9099
chore(agw): indentation in Dockerfile is fixed (#13992)
mpfirrmann Sep 23, 2022
30c62dc
fix(agw): fix envoy controller docker image name (#13973)
wolfseb Sep 23, 2022
44cae07
chore(agw): Remove unused code from pydep (#14003)
sebathomas Sep 23, 2022
35fbec2
chore(agw): s1ap_utils.py is cleaned up (#13854)
mpfirrmann Sep 23, 2022
ba1c9d7
feat(agw): test_sctp_shutdown_while_mme_is_stopped.py is adapted to c…
mpfirrmann Sep 26, 2022
8479382
fix: missing enodebd folders are added to magma debian build (#14007)
nstng Sep 26, 2022
d93dad7
chore: integ test magma restart waits for pipelined to be initialized…
vktng Sep 26, 2022
667fc15
fix(agw): Allow containerized magmad to restart services (#13993)
sebathomas Sep 26, 2022
23d1c89
Merge remote-tracking branch 'upstream/master' into 11191_move_enb_co…
rsarwad Sep 27, 2022
f571fb5
Fixed compilation error
rsarwad Sep 27, 2022
10f717f
fix(mme): Handling qosflowFailedForAddorModify in session modificati…
ajay-kashyap Sep 27, 2022
f1a3080
fix(agw): make redis save state after cleaning the db (#13994)
mpfirrmann Sep 27, 2022
63aa717
chore(deps): bump yajl-ruby in /orc8r/cloud/docker/fluentd_daemon (#1…
dependabot[bot] Sep 27, 2022
2658f50
fix(agw): sctpd needs explicit restart for docker as it is restarted …
Sep 27, 2022
9a01c50
chore: Publish test results for the Bazel and Debian integration and …
vktng Sep 27, 2022
d9f907d
chore: an integ test checks if all magma services are running (#14013)
nstng Sep 27, 2022
00c6540
chore: the init system check is less chatty (#14004)
nstng Sep 27, 2022
0b29b74
chore(agw): restart of sctpd is adapted (#14000)
mpfirrmann Sep 27, 2022
408bfc9
fix(agw): fix incorrect asserts in agw integ tests (#14012)
wolfseb Sep 28, 2022
e736de2
fix(agw): fix certificate issue for containerized AGW deployment (#13…
wolfseb Sep 28, 2022
8028302
fix: boolean arguments in fabric calls are interpreted correctly (#14…
nstng Sep 28, 2022
228c859
refactor(orc8r): Remove proto.Clone calls (#14029)
MoritzThomasHuebner Sep 29, 2022
8c09608
Addressed review comments
rsarwad Sep 28, 2022
8aac26b
Merge remote-tracking branch 'upstream/master' into 11191_move_enb_co…
rsarwad Sep 29, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
11 changes: 9 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@ startup --host_jvm_args="-Xmx8g"
build --announce_rc
build --color=yes

build:production --config=lsan --strip=never --copt=-O3
build:production --config=lsan --copt=-O3

# C/C++ CONFIGS
build --cxxopt=-std=c++14
build --compilation_mode=dbg
# Create debug information only for magma binaries (not for external dependencies).
# --compilation_mode=dbg would also create debug information of external dependencies
# and increase the size of artifacts drastically.
# Needs --strip=never so that debug information is not removed by the linker.
# See https://bazel.build/docs/user-manual#compilation-mode and
# https://bazel.build/docs/user-manual#strip
build --strip=never
build --per_file_copt=^lte/gateway/c/.*$@-g

# DEFAULT TEST CONFIGURATION
# Please read the GH issue #13073 before adding "test" options.
Expand Down
56 changes: 11 additions & 45 deletions .devcontainer/bazel-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ RUN echo "Install general purpose packages" && \
apt-get install -y --no-install-recommends \
apt-transport-https \
apt-utils \
# dependencies of FreeDiameter
bison \
build-essential \
ca-certificates \
Expand All @@ -29,39 +28,30 @@ RUN echo "Install general purpose packages" && \
git \
gnupg2 \
g++ \
# dependency of mobilityd (tests)
iproute2 \
# dependency of python services (e.g. magmad)
iputils-ping \
iproute2 `# dependency of mobilityd (tests)` \
iputils-ping `# dependency of python services (e.g. magmad)` \
flex \
libconfig-dev \
# dependency of @sentry_native//:sentry
libcurl4-openssl-dev \
# dependencies of oai/mme
libcurl4-openssl-dev `# dependency of @sentry_native//:sentry` \
libczmq-dev \
libgcrypt-dev \
libgmp3-dev \
libidn11-dev \
libsctp1 \
libsqlite3-dev \
# dependency of sctpd
libsctp-dev \
libsctp-dev `# dependency of sctpd` \
libssl-dev \
# dependency of pip systemd
libsystemd-dev \
libsystemd-dev `# dependency of pip systemd` \
lld \
# dependency of python services (e.g. magmad)
net-tools \
# dependency of python services (e.g. pipelined)
netbase \
net-tools `# dependency of python services (e.g. magmad)` \
netbase `# dependency of python services (e.g. pipelined)` \
python${PYTHON_VERSION} \
python-is-python3 \
python3-distutils `# dependency of bazel pip_parse rule` \
software-properties-common \
# dependency of python services (e.g. magmad)
systemd \
systemd `# dependency of python services (e.g. magmad)` \
unzip \
# dependency of liagent
uuid-dev \
uuid-dev `# dependency of liagent` \
vim \
wget \
zip
Expand All @@ -82,38 +72,14 @@ RUN apt-get install -y --no-install-recommends \
libpcap-dev=1.9.1-3 \
libmnl-dev=1.0.4-2

## Install Fmt (Folly Dep)
RUN git clone https://github.com/fmtlib/fmt.git && \
cd fmt && \
mkdir _build && \
cd _build && \
cmake -DBUILD_SHARED_LIBS=ON -DFMT_TEST=0 .. && \
make -j"$(nproc)" && \
make install && \
cd / && \
rm -rf fmt

# Facebook Folly C++ lib
# Note: "Because folly does not provide any ABI compatibility guarantees from
# commit to commit, we generally recommend building folly as a static library."
# Here we checkout the hash for v2021.02.22.00 (arbitrary recent version)
RUN git clone --depth 1 --branch v2021.02.15.00 https://github.com/facebook/folly && \
cd /folly && \
mkdir _build && \
cd _build && \
cmake -DBUILD_SHARED_LIBS=ON .. && \
make -j"$(nproc)" && \
make install && \
cd / && \
rm -rf folly

# setup magma artifactories and install magma dependencies
RUN wget -qO - https://artifactory.magmacore.org:443/artifactory/api/gpg/key/public | apt-key add - && \
add-apt-repository 'deb https://artifactory.magmacore.org/artifactory/debian-test focal-ci main' && \
add-apt-repository 'deb https://artifactory.magmacore.org/artifactory/debian-test focal-1.7.0 main' && \
apt-get update -y && \
apt-get install -y --no-install-recommends \
bcc-tools \
libfolly-dev \
liblfds710 \
oai-asn1c \
oai-gnutls \
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/backport-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ jobs:
)
)
steps:
- run: |
echo '{
"prTitle": "{commitMessages} [backport to {targetBranch}]"
}' > .backportrc.json
- name: Backport Action
uses: sqren/backport-github-action@f54e19901f2a57f8b82360f2490d47ee82ec82c6 # [email protected]
with:
Expand Down
22 changes: 10 additions & 12 deletions .github/workflows/bazel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,10 @@ jobs:

bazel_build_and_test:
needs: path_filter
# Only run workflow if this is a scheduled run on master branch,
# if the workflow has been triggered manually or if it is a pull_request
# that skip-duplicate-action wants to run again.
# Only run workflow if this is a push to the magma repository,
# if the workflow has been triggered manually or if it is a pull_request.
if: |
(github.event_name == 'schedule' && github.ref == 'refs/heads/master') ||
(github.event_name == 'push' && github.repository_owner == 'magma') ||
needs.path_filter.outputs.files_changed == 'true' ||
github.event_name == 'workflow_dispatch'
strategy:
Expand Down Expand Up @@ -163,7 +162,7 @@ jobs:
echo "Available storage:"
df -h
- name: Notify failure to slack
if: failure() && (github.event_name == 'push' || github.event_name == 'schedule') && github.repository_owner == 'magma'
if: failure() && github.event_name == 'push' && github.repository_owner == 'magma'
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7 # [email protected]
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_BAZEL_CI }}
Expand Down Expand Up @@ -219,11 +218,10 @@ jobs:

bazel_package:
needs: path_filter
# Only run workflow if this is a scheduled run on master branch,
# if the workflow has been triggered manually or if it is a pull_request
# that skip-duplicate-action wants to run again.
# Only run workflow if this is a push to the magma repository,
# if the workflow has been triggered manually or if it is a pull_request.
if: |
(github.event_name == 'schedule' && github.ref == 'refs/heads/master') ||
(github.event_name == 'push' && github.repository_owner == 'magma') ||
needs.path_filter.outputs.files_changed == 'true' ||
github.event_name == 'workflow_dispatch'
name: Bazel Package Job
Expand Down Expand Up @@ -266,7 +264,7 @@ jobs:
echo "Available storage:"
df -h
- name: Notify failure to slack
if: failure() && (github.event_name == 'push' || github.event_name == 'schedule') && github.repository_owner == 'magma'
if: failure() && github.event_name == 'push' && github.repository_owner == 'magma'
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7 # [email protected]
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_BAZEL_CI }}
Expand All @@ -288,7 +286,7 @@ jobs:
run: |
./bazel/scripts/check_py_bazel.sh
- name: Notify failure to slack
if: failure() && (github.event_name == 'push' || github.event_name == 'schedule') && github.repository_owner == 'magma'
if: failure() && github.event_name == 'push' && github.repository_owner == 'magma'
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7 # [email protected]
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_BAZEL_CI }}
Expand All @@ -310,7 +308,7 @@ jobs:
run: |
./bazel/scripts/check_c_cpp_bazel.sh
- name: Notify failure to slack
if: failure() && (github.event_name == 'push' || github.event_name == 'schedule') && github.repository_owner == 'magma'
if: failure() && github.event_name == 'push' && github.repository_owner == 'magma'
uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7 # [email protected]
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_BAZEL_CI }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
run: |
pip3 install --upgrade pip
pip3 install ansible fabric3 jsonpickle requests PyYAML
vagrant plugin install vagrant-vbguest vagrant-vbguest vagrant-mutate
vagrant plugin install vagrant-disksize vagrant-vbguest vagrant-mutate vagrant-reload
- name: Open up network interfaces for VM
run: |
sudo mkdir -p /etc/vbox/
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/cloud-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ jobs:
with:
filters: |
filesChanged:
- [".github/workflows/cloud-workflow.yml", "lte/protos/**", "cwf/cloud/**", "feg/cloud/**", "lte/cloud/**", "orc8r/**"]
- ".github/workflows/cloud-workflow.yml"
- "lte/protos/**"
- "cwf/cloud/**"
- "feg/cloud/**"
- "lte/cloud/**"
- "orc8r/**"
- "dp/cloud/**"
- "dp/protos/**"
- name: Save should_not_skip output
if: always()
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cwf-integ-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
run: |
pip3 install --upgrade pip
pip3 install ansible fabric3 jsonpickle requests PyYAML firebase_admin
vagrant plugin install vagrant-vbguest
vagrant plugin install vagrant-vbguest vagrant-reload vagrant-disksize
- uses: actions/download-artifact@f023be2c48cc18debc3bacd34cb396e0295e2869 # pin@v2
with:
name: docker-images
Expand Down
52 changes: 0 additions & 52 deletions .github/workflows/dp-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
runs-on: ubuntu-latest
outputs:
cc: ${{ steps.filter.outputs.cc }}
am: ${{ steps.filter.outputs.am }}
rc: ${{ steps.filter.outputs.rc }}
db: ${{ steps.filter.outputs.db }}
helm: ${{ steps.filter.outputs.helm }}
Expand All @@ -52,14 +51,6 @@ jobs:
- 'dp/protos/**'
- 'dp/cloud/go/protos/**'
- 'dp/cloud/go/active_mode_controller/protos'
am:
- '.github/workflows/dp-workflow.yml'
- 'dp/cloud/go/active_mode_controller/**'
- 'dp/cloud/docker/go/active_mode_controller/**'
- 'dp/cloud/python/magma/db_service/**'
- 'dp/protos/**'
- 'dp/cloud/go/protos/**'
- 'dp/cloud/go/active_mode_controller/protos'
rc:
- '.github/workflows/dp-workflow.yml'
- 'dp/cloud/python/magma/radio_controller/**'
Expand Down Expand Up @@ -139,47 +130,6 @@ jobs:
with:
flags: unittests,configuration-controller
name: codecov-configuration-controller
fail_ci_if_error: false
verbose: true

active_mode_controller_unit_tests:
needs: path_filter
if: ${{ needs.path_filter.outputs.am == 'true' }}
name: "Active mode controller unit tests"
runs-on: ubuntu-latest

defaults:
run:
working-directory: dp/cloud/go/active_mode_controller
env:
GO_VERSION: 1.18.3

steps:
- name: Checkout code
uses: actions/checkout@7884fcad6b5d53d10323aee724dc68d8b9096a2e # pin@v2

- name: Set up Go ${{ env.GO_VERSION }}
uses: actions/setup-go@b22fbbc2921299758641fab08929b4ac52b32923 # pin@v3
with:
go-version: ${{ env.GO_VERSION }}

- name: Run Go linter
uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 # pin@v2
with:
version: v1.46.2
working-directory: dp/cloud/go/active_mode_controller
skip-go-installation: true

- name: Run Go tests
run: |
go test ./... -v -race -coverprofile=coverage.txt -covermode=atomic

- name: Upload coverage to Codecov
uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # pin@v2
with:
flags: unittests,active-mode-controller
name: codecov-active-mode-controller
fail_ci_if_error: false
verbose: true

radio_controller_unit_tests:
Expand Down Expand Up @@ -258,7 +208,6 @@ jobs:
with:
flags: unittests,radio-controller
name: codecov-radio-controller
fail_ci_if_error: false
verbose: true

db_migration_check:
Expand Down Expand Up @@ -354,7 +303,6 @@ jobs:
with:
flags: unittests,db-service
name: codecov-db-service
fail_ci_if_error: false
verbose: true

integration_tests_orc8r:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/federated-integ-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ jobs:
run: |
pip3 install --upgrade pip
pip3 install ansible fabric3 jsonpickle requests PyYAML firebase_admin
vagrant plugin install vagrant-vbguest vagrant-scp
vagrant plugin install vagrant-vbguest vagrant-disksize vagrant-scp vagrant-reload
- name: Vagrant Host prerequisites for federated integ test
run: |
cd ${{ env.AGW_ROOT }} && fab open_orc8r_port_in_vagrant
cd ${{ env.MAGMA_ROOT }} && mkdir -p .cache/test_certs/ && mkdir -p .cache/feg/ && touch snowflake
cd ${{ env.MAGMA_ROOT }} && mkdir -p .cache/test_certs/ && mkdir -p .cache/feg/
cd ${{ env.MAGMA_ROOT }}/.cache/feg/ && touch snowflake
- name: Open up network interfaces for VM
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/golang-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ jobs:
uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # pin@v2
with:
flags: src_go
fail_ci_if_error: true
verbose: true
- name: Extract commit title
id: commit
Expand Down
Loading