11190 spgw ue context ht #27

rsarwad · 2022-09-12T13:53:29Z

Summary

Test Plan

Additional Information

This change is backwards-breaking

Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-09-12T13:53:43Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-12T13:54:15Z

❌ The Semantic PR check ended with status failure. See instructions on formatting your commit and pull request titles.

github-actions · 2022-09-12T13:55:44Z

lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp

      if (p1->sgw_s11_teid == teid) {
        LIST_REMOVE(p1, entries);
-        free_wrapper((void**)&p1);
+        free_cpp_wrapper((void**)&p1);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

github-actions · 2022-09-12T13:55:45Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state.cpp

      p2 = LIST_NEXT(p1, entries);
      LIST_REMOVE(p1, entries);
-      free_wrapper((void**)&p1);
+      free_cpp_wrapper((void**)&p1);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

github-actions · 2022-09-12T13:55:45Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_handlers.cpp

      if (p1->sgw_s11_teid == teid) {
        LIST_REMOVE(p1, entries);
-        free_wrapper((void**)&p1);
+        free_cpp_wrapper((void**)&p1);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

github-actions · 2022-09-12T13:55:45Z

lte/gateway/c/core/oai/test/spgw_task/test_spgw_state_converter.cpp

    EXPECT_TRUE(!memcmp(&want_sgw.last_known_cell_Id,
                        &got_sgw.last_known_cell_Id,
                        sizeof(want_sgw.last_known_cell_Id)));
+    sgw_free_ue_context((void**)&final_ctx);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

Signed-off-by: Rashmi <[email protected]>

…text_ht Signed-off-by: Rashmi <[email protected]>

Signed-off-by: kharade <[email protected]> Signed-off-by: kharade <[email protected]>

Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

…ent (magma#13878) The current setup does not require duplication of defined flags. This is not only manual effort in maintenance, but also discouraged within the documentation. Also see https://docs.codecov.com/docs/flags#step-2-flag-management-in-yaml. Signed-off-by: Fritz Lehnert <[email protected]>

…mands (magma#13874) * chore(agw): Create convenient aliases in magma-dev VM for service commands Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected] Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Remove service make targets Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected] Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

…agma#13865) Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected] Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

…magma#13916) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

…ol (magma#13472) Signed-off-by: Sathyaj27 <[email protected]> Signed-off-by: Sathyaj27 <[email protected]>

* chore(dp): New AmcManager CreateRequest func Signed-off-by: Jarosław Jaszczuk <[email protected]> * imports Signed-off-by: Jarosław Jaszczuk <[email protected]> * fix TestWithinTx tests Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

…ma#13923) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

Signed-off-by: Wojciech Sadowy <[email protected]> Signed-off-by: Wojciech Sadowy <[email protected]> Co-authored-by: Wojciech Sadowy <[email protected]>

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

* chore: sctpd bazel build is cleaned-up Signed-off-by: Nils Semmelrock <[email protected]> * chore: skeleton for bazel magma deb build is added Signed-off-by: Nils Semmelrock <[email protected]> * chore: service definitions are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: ebpf files are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: c binaries are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: configuration files are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: misc configuration files are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: python runfiles can be expanded for packaging Signed-off-by: Nils Semmelrock <[email protected]> * chore: python scripts and dependencies are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: go binary (envoy_controller) is added Signed-off-by: Nils Semmelrock <[email protected]> * chore: python services are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: magma system dependencies are added Signed-off-by: Nils Semmelrock <[email protected]> * chore: post install script is added Signed-off-by: Nils Semmelrock <[email protected]> * chore: cpp debug symbols are only created for magma code (size of artifacts is decreased) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

Signed-off-by: Lars Kreutzer <[email protected]> Co-authored-by: Jan Heidbrink <[email protected]> Co-authored-by: Nils Semmelrock <[email protected]> Co-authored-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]> Co-authored-by: Jan Heidbrink <[email protected]> Co-authored-by: Nils Semmelrock <[email protected]>

* feat(agw): envoy controller is dockerized Signed-off-by: Christian Krämer <[email protected]> * feat(agw): envoy namespace is now configured by the envoy service Signed-off-by: Christian Krämer <[email protected]> * feat(agw): install dhclient in pipelined container Signed-off-by: Sebastian Wolf <[email protected]> Signed-off-by: Christian Krämer <[email protected]> Signed-off-by: Sebastian Wolf <[email protected]> Co-authored-by: Christian Krämer <[email protected]> Co-authored-by: Marco Pfirrmann <[email protected]>

) * feat(agw): restart functions can now handle docker containers and systemd services Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): handling of redis states is improved Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): cleanup redis if not empty Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): service restart is adapted to new syntax Signed-off-by: Marco Pfirrmann <[email protected]> Signed-off-by: Marco Pfirrmann <[email protected]>

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

…e services not starting in integ tests. Add debug output to ntpdate as this seems to cause the failed integ tests. (magma#14238) Signed-off-by: Christian Krämer <[email protected]>

Signed-off-by: Marco Pfirrmann <[email protected]> Signed-off-by: Marco Pfirrmann <[email protected]>

Too much logic was deleted to fix the typing. This restores the default path selection, which makes it possible to run load tests again. Signed-off-by: Sebastian Thomas <[email protected]> Signed-off-by: Sebastian Thomas <[email protected]>

Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Lars Kreutzer <[email protected]>

…es (magma#14309) Testing: - verified Registration Falure(Illegal UE) - verified Periodic Registration Signed-off-by: ganeshg87 <[email protected]> Signed-off-by: ganeshg87 <[email protected]>

…manager class (magma#14116) fix(agw): Modified code at s1ap to remove dependency on common state manager class Signed-off-by: Rashmi <[email protected]>

The test verb inherits settings for the build verb. Settings for the build and test verb should largely be the same for better cache reuse. Signed-off-by: Jan Heidbrink <[email protected]>

magma#13974) Signed-off-by: vagrant <[email protected]> Signed-off-by: vagrant <[email protected]> Co-authored-by: vagrant <[email protected]>

* fix(ci): ignore exit status from single test sets * fix(ci): move the comment the correct place Signed-off-by: Fritz Lehnert <[email protected]>

Signed-off-by: Krisztián Varga <[email protected]> Signed-off-by: Krisztián Varga <[email protected]>

Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

Signed-off-by: Sebastian Thomas <[email protected]>

Signed-off-by: Rashmi <[email protected]>

… handled by systemd-timesyncd. Eventd startup will fail when no ntp service is reachable. Ntp servers seem to be blocked regularly on github actions/azure due to ddos issues which makes test_services_are_running.py fail. (magma#14315) Signed-off-by: Christian Krämer <[email protected]>

Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

…#14233) Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

Signed-off-by: Jan Heidbrink <[email protected]>

…dard #ci channel (magma#14330) Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

Pytest fails calling the constructor. But moving the magma_utils initialization to setUp works. Signed-off-by: Sebastian Thomas <[email protected]>

This ensures that Bazel recognizes the actions used for build and test to be the same options, and thus reuse the built artifacts for testing. Signed-off-by: Jan Heidbrink <[email protected]>

Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

Signed-off-by: Rashmi <[email protected]>

Signed-off-by: shashidhar-patil <[email protected]> Signed-off-by: shashidhar-patil <[email protected]>

…rkflow (magma#14333) Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

github-actions · 2022-11-02T10:24:58Z

bazel/external/requirements_README.md

+       `pip-compile --upgrade-package --generate-hashes --output-file=requirements.txt requirements.in`

 The changes are then automatically included in the next Bazel build process.



[markdownlint-fix] _{reported by reviewdog 🐶}

Suggested change

…text_ht Signed-off-by: Rashmi <[email protected]>

fix(agw): Modiifed code to port hash list of ue contexts to protobuf map

10b1a0c

Signed-off-by: Rashmi <[email protected]>

github-actions bot added the component: agw label Sep 12, 2022

github-actions bot reviewed Sep 12, 2022

View reviewed changes

fix(agw): Modiifed code to port hash list of ue contexts to protobuf map

62bec19

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11190_spgw_ue_context_ht branch from 0fbc0f5 to 62bec19 Compare September 12, 2022 14:26

Merge remote-tracking branch 'upstream/master' into 11190_spgw_ue_con…

b621678

…text_ht Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: ci component: cwf component: docs component: orc8r and removed component: agw labels Sep 13, 2022

orion-belt and others added 17 commits September 13, 2022 13:29

feat(ci): Add federated integ test for HSS (magma#13805)

43f3d01

Signed-off-by: kharade <[email protected]> Signed-off-by: kharade <[email protected]>

chore(agw): Tidy up fabfile (magma#13872)

e8b2d80

Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

chore(ci): Parallelize the LTE integ tests and the sudo python tests (m…

9d4a75d

…agma#13865) Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected] Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

fix: ansible is pinned because of ansible-core 2.13.4 breaking change (…

88b6e7f

…magma#13916) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

fix(amf): Adding Reject if Static ip configured is in subset of ip_po…

0f9a6d3

…ol (magma#13472) Signed-off-by: Sathyaj27 <[email protected]> Signed-off-by: Sathyaj27 <[email protected]>

chore(dp): Implement AmcManager DeleteCbsd func (magma#13921)

1a22cca

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

fix: golangci is upgraded to 1.47.3 in order to support generics (mag…

5444521

…ma#13923) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

fix(dp): make 37 default value for max_eirp (magma#13922)

0589db4

Signed-off-by: Wojciech Sadowy <[email protected]> Signed-off-by: Wojciech Sadowy <[email protected]> Co-authored-by: Wojciech Sadowy <[email protected]>

chore(dp): Implement AmcManager UpdateCbsd func (magma#13927)

da0d251

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

chore(dp): WithinTx should not suppress panic (magma#13933)

1212843

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

crasu and others added 4 commits October 27, 2022 10:04

fix(ci): Add debug output to in order to make it easier to investigat…

2c6f85c

…e services not starting in integ tests. Add debug output to ntpdate as this seems to cause the failed integ tests. (magma#14238) Signed-off-by: Christian Krämer <[email protected]>

fix(ci): format html output correctly (magma#14295)

918645c

Signed-off-by: Marco Pfirrmann <[email protected]> Signed-off-by: Marco Pfirrmann <[email protected]>

Catching exception on failing to allocate memory

0f7be0e

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11190_spgw_ue_context_ht branch from 1a21c6c to 0f7be0e Compare October 27, 2022 09:39

LKreutzer and others added 10 commits October 27, 2022 11:37

chore(ci): Remove dead env variables in agw-workflow (magma#14301)

53025c6

Signed-off-by: Lars Kreutzer <[email protected]>

fix(amf): Handled Registration and Periodic Registration Failure Issu…

55c8e79

…es (magma#14309) Testing: - verified Registration Falure(Illegal UE) - verified Periodic Registration Signed-off-by: ganeshg87 <[email protected]> Signed-off-by: ganeshg87 <[email protected]>

fix(agw): Modified code at s1ap to remove dependency on common state …

9419ae6

…manager class (magma#14116) fix(agw): Modified code at s1ap to remove dependency on common state manager class Signed-off-by: Rashmi <[email protected]>

chore: Set parameter for both build and test (magma#14311)

4e0cae5

The test verb inherits settings for the build verb. Settings for the build and test verb should largely be the same for better cache reuse. Signed-off-by: Jan Heidbrink <[email protected]>

fix(amf): QOS flow descriptors are not updated correctly as configured (

f74615c

magma#13974) Signed-off-by: vagrant <[email protected]> Signed-off-by: vagrant <[email protected]> Co-authored-by: vagrant <[email protected]>

fix(ci): ignore exit status from single test sets (magma#14278)

dc9cd7b

* fix(ci): ignore exit status from single test sets * fix(ci): move the comment the correct place Signed-off-by: Fritz Lehnert <[email protected]>

chore: Introduce "util_script" and "service" Bazel tags (magma#14215)

bdab335

Signed-off-by: Krisztián Varga <[email protected]> Signed-off-by: Krisztián Varga <[email protected]>

chore(ci): Unify workflow names (magma#14229)

20d3451

Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

refactor(pipelined): Use netifaces to get mac addresses (magma#14303)

1fea4c3

Signed-off-by: Sebastian Thomas <[email protected]>

Removed the null check

a35732f

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11190_spgw_ue_context_ht branch from 0754a91 to a35732f Compare October 28, 2022 13:22

crasu and others added 11 commits October 28, 2022 15:27

chore(agw): Bazelify the load_tests (magma#14317)

919380f

Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

chore(ci): Remove sudo tests from make LTE integ test workflow (magma…

41b18da

…#14233) Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Cameron Voisey <[email protected]>

chore(agw): Create Python environment with bazel (magma#14266)

85b9025

Signed-off-by: Jan Heidbrink <[email protected]>

chore(ci): Send all CI Slack notifications for Bazel jobs to the stan…

88dfab2

…dard #ci channel (magma#14330) Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

test(agw): Fix broken integration test (magma#14331)

bfb1473

Pytest fails calling the constructor. But moving the magma_utils initialization to setUp works. Signed-off-by: Sebastian Thomas <[email protected]>

fix: bazel build and test verbs use same parameter order (magma#14336)

e5a78b2

This ensures that Bazel recognizes the actions used for build and test to be the same options, and thus reuse the built artifacts for testing. Signed-off-by: Jan Heidbrink <[email protected]>

fix(ci): Fix upload error in agw-coverage workflow (magma#14332)

cf497c2

Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

fix(agw): Modified code to fix the issue 14244 (magma#14327)

8123305

Signed-off-by: Rashmi <[email protected]>

fix(amf): Added logs for release cause (magma#14337)

484f77c

Signed-off-by: shashidhar-patil <[email protected]> Signed-off-by: shashidhar-patil <[email protected]>

chore(ci): Replace to-be-deprecated set-output statement in GitHub wo…

5a72ab8

…rkflow (magma#14333) Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

github-actions bot reviewed Nov 2, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/master' into 11190_spgw_ue_con…

a149ec6

…text_ht Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11190_spgw_ue_context_ht branch from cd8575e to a149ec6 Compare November 2, 2022 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

11190 spgw ue context ht #27

11190 spgw ue context ht #27

Uh oh!

rsarwad commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

github-actions bot Sep 12, 2022

Uh oh!

github-actions bot Sep 12, 2022

Uh oh!

github-actions bot Sep 12, 2022

Uh oh!

github-actions bot Sep 12, 2022

Uh oh!

github-actions bot Nov 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		`pip-compile --upgrade-package --generate-hashes --output-file=requirements.txt requirements.in`

		The changes are then automatically included in the next Bazel build process.

11190 spgw ue context ht #27

Are you sure you want to change the base?

11190 spgw ue context ht #27

Uh oh!

Conversation

rsarwad commented Sep 12, 2022

Summary

Test Plan

Additional Information

Uh oh!

github-actions bot commented Sep 12, 2022

Howto

More info

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

github-actions bot Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants