fix(agw): Modified code to port s_plus_p_gw_eps_bearer_context_information_t to protobuf structure in spgw task #28

rsarwad · 2022-12-16T16:51:37Z

Summary

fix(agw): Modified code to port s_plus_p_gw_eps_bearer_context_information_t to protobuf structure in spgw task

Test Plan

Executed unit test cases and s1ap integ_tests

… protobuf structure Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-12-16T16:52:04Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-12-16T16:52:44Z

lte/gateway/c/core/oai/test/spgw_task/test_pgw_pco.cpp

-  pco_req.protocol_or_container_ids[0].id =
-      PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING;
+  magma::lte::oai::PcoProtocol* pco_protocol = pco_req.add_pco_protocol();
+  pco_protocol->set_id(PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING);


[misspell] _{reported by reviewdog 🐶}
"SIGNALLING" is a misspelling of "SIGNALING"

github-actions · 2022-12-16T16:54:16Z

Oops! Looks like you failed the AGW Build & Format Python.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the AGW Build & Format Python after the last commit.

github-actions · 2022-12-16T16:54:12Z

lte/gateway/c/core/oai/lib/mobility_client/MobilityClientAPI.hpp

 #define RPC_CLIENT_H

 #include "stdint.h"
+#include <string>


[cpplint] _{reported by reviewdog 🐶}
Found C++ system header after other header. Should be: MobilityClientAPI.h, c system, c++ system, other. [build/include_order] [4]

github-actions · 2022-12-16T16:54:13Z

lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp

+    log_proto_t module,
+    magma::lte::oai::S11BearerContext* sgw_context_information)
+//-----------------------------------------------------------------------------
+{


[cpplint] _{reported by reviewdog 🐶}
{ should almost always be at the end of the previous line [whitespace/braces] [4]

github-actions · 2022-12-16T16:54:13Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp

+    sgw_context_p->set_mme_teid_s11(session_req_pP->sender_fteid_for_cp.teid);
+    sgw_context_p->set_sgw_teid_s11_s4(new_endpoint_p->local_teid);
+    if (session_req_pP->trxn) {
+      sgw_context_p->set_trxn((char*)session_req_pP->trxn);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:13Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp

-    create_session_response_p->peer_ip.s_addr =
-        new_bearer_ctxt_info_p->sgw_eps_bearer_context_information
-            .mme_ip_address_S11.address.ipv4_address.s_addr;
+        (void*)new_bearer_ctxt_info_p->sgw_eps_bearer_context().trxn().c_str();


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:13Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp

+  memcpy(imsi.digit,
+         new_bearer_ctxt_info_p->sgw_eps_bearer_context().imsi().c_str(),
+         new_bearer_ctxt_info_p->sgw_eps_bearer_context().imsi().size());
+  char* apn = (char*)new_bearer_ctxt_info_p->sgw_eps_bearer_context()


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:15Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_converter.cpp

-  if (procedures != nullptr) {
-    pgw_base_proc_t* base_proc = nullptr;
+  if (session_request->trxn != nullptr) {
+    proto->set_trxn((char*)session_request->trxn);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:15Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_converter.cpp

-      }
-    }
+  proto->set_teid(session_request->teid);
+  proto->set_imsi((char*)session_request->imsi.digit);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:15Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_handlers.cpp

+                                  eps_bearer_ctxt->s_gw_teid_S5_S8_up);
+      }
+
+      // TODO Need to add handling on failing to delete s1-u tunnel rules from


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2022-12-16T16:54:15Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_handlers.cpp

+      if ((eps_bearer_ctxt->paa.pdn_type == IPv6) ||
+          (eps_bearer_ctxt->paa.pdn_type == IPv4_AND_v6)) {
+        char ip6_str[INET6_ADDRSTRLEN];
+        inet_ntop(AF_INET6, (void*)&eps_bearer_ctxt->paa.ipv6_address, ip6_str,


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

github-actions · 2022-12-16T16:54:16Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_state.cpp

+void sgw_s8_free_pdn_connection(sgw_pdn_connection_t* pdn_connection_p) {
+  if (pdn_connection_p) {
+    if (pdn_connection_p->apn_in_use) {
+      free_wrapper((void**)&pdn_connection_p->apn_in_use);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

…txt_changes Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Rashmi <[email protected]>

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-12-22T09:54:03Z

.devcontainer/Dockerfile

 ##### libgtpnl
 # review https://github.com/OPENAIRINTERFACE/openair-cn/blob/master/build/tools/build_helper.gtpnl
-RUN git clone https://git.osmocom.org/libgtpnl && \
+RUN git clone https://gitea.osmocom.org/cellular-infrastructure/libgtpnl && \


⚠️ [hadolint] <DL3003> _{reported by reviewdog 🐶}
Use WORKDIR to switch to a directory

github-actions · 2022-12-22T09:57:00Z

Oops! Looks like you failed the PR Check DCO. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the PR Check DCO after the last commit.

…txt_changes Signed-off-by: Rashmi <[email protected]>

Signed-off-by: Rashmi <[email protected]>

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions · 2023-01-02T07:19:11Z

nms/e2e_test_setup.sh

 while [ $i -lt 60 ]
 do
-    val=$(docker-compose -f docker-compose-e2e.yml logs magmalte 2>&1 | grep 'Production server started on port 8081' | wc -l)
+    val=$(docker compose -f docker-compose-e2e.yml logs magmalte 2>&1 | grep 'Production server started on port 8081' | wc -l)


[shellcheck] _{reported by reviewdog 🐶}
Consider using grep -c instead of grep|wc -l. SC2126

github-actions · 2023-01-02T07:19:33Z

cwf/k8s/cwf_operator/README.md

 ```

 Then register each gateway:
 ```console


[markdownlint-fix] _{reported by reviewdog 🐶}

Suggested change

```console

```console

github-actions · 2023-01-02T07:19:33Z

nms/README.md

+docker compose exec magmalte yarn setAdminPassword host ADMIN_USER_EMAIL ADMIN_USER_PASSWORD
 ```

 Access the `host` (http://host.localhost:8081/host) portal to create your first organization.


[markdownlint-fix] _{reported by reviewdog 🐶}

Suggested change

Access the `host` (http://host.localhost:8081/host) portal to create your first organization.

Access the `host` (<http://host.localhost:8081/host>) portal to create your first organization.

…txt_changes Signed-off-by: Rashmi <[email protected]>

rsarwad added 8 commits November 25, 2022 16:50

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

6076675

… protobuf structure Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

504e00d

…txt_changes Signed-off-by: Rashmi <[email protected]>

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

b146a62

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

aca564e

…txt_changes Signed-off-by: Rashmi <[email protected]>

Cleaned up the code

cae3d2b

Signed-off-by: Rashmi <[email protected]>

Checking in the updated spgw_state.proto/pb.go file

78e007b

Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0d9d9ec

…txt_changes Signed-off-by: Rashmi <[email protected]>

Fixed the issue found during s1ap integ_tests

8cd5237

Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: agw component: orc8r labels Dec 16, 2022

github-actions bot reviewed Dec 16, 2022

View reviewed changes

rsarwad added 4 commits December 16, 2022 22:26

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

986ebca

…txt_changes Signed-off-by: Rashmi <[email protected]>

Removed the file, test_spgw_state_converter.cpp

2cf7c66

Signed-off-by: Rashmi <[email protected]>

Addressed self comments

492cdd0

Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

bc721b4

…txt_changes Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_spgw_teid_ctxt_changes branch from b931239 to bc721b4 Compare December 20, 2022 09:56

rsarwad added 3 commits December 21, 2022 17:34

Addressed self review comments

2b5e6c7

Signed-off-by: Rashmi <[email protected]>

Addressed review comment

b58948f

Signed-off-by: Rashmi <[email protected]>

Addressed review comment

cf5ec0b

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_spgw_teid_ctxt_changes branch 2 times, most recently from cf5ec0b to d1cd375 Compare December 22, 2022 09:14

rsarwad added 3 commits December 22, 2022 14:44

Fixed cpp lint errors

d1cd375

Signed-off-by: Rashmi <[email protected]>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

73d84cb

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

9b90fdc

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions bot added the component: ci label Dec 22, 2022

github-actions bot reviewed Dec 22, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

30593e8

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: cwf component: feg and removed component: agw labels Dec 23, 2022

rsarwad added 3 commits December 27, 2022 10:49

Addressed review comment

d7256a0

Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

293a884

…txt_changes Signed-off-by: Rashmi <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0e1e596

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: agw and removed component: cwf component: ci component: feg labels Dec 28, 2022

rsarwad force-pushed the 11191_spgw_teid_ctxt_changes branch from cb769de to 0e1e596 Compare January 2, 2023 06:53

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

f34345e

…txt_changes Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: ci component: cwf component: dp component: feg and removed component: agw component: orc8r labels Jan 2, 2023

github-actions bot reviewed Jan 2, 2023

View reviewed changes

github-actions bot added component: agw component: orc8r and removed component: ci component: feg component: dp component: cwf labels Jan 2, 2023

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

348dd09

…txt_changes Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_spgw_teid_ctxt_changes branch from e55295a to 348dd09 Compare January 4, 2023 05:14

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

4f0a450

…txt_changes Signed-off-by: Rashmi <[email protected]>

	Access the `host` (http://host.localhost:8081/host) portal to create your first organization.
	Access the `host` (<http://host.localhost:8081/host>) portal to create your first organization.

fix(agw): Modified code to port s_plus_p_gw_eps_bearer_context_information_t to protobuf structure in spgw task #28

Are you sure you want to change the base?

fix(agw): Modified code to port s_plus_p_gw_eps_bearer_context_information_t to protobuf structure in spgw task #28

Uh oh!

Conversation

rsarwad commented Dec 16, 2022

Summary

Test Plan

Uh oh!

github-actions bot commented Dec 16, 2022

Howto

More info

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Howto

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Howto

Uh oh!

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 16, 2022 •

edited

Loading

github-actions bot commented Dec 22, 2022 •

edited

Loading