Merge pull request #49 from rsdefever/switch-to-numeric-key

Switch JSON dict key to atomic number
rsdefever · Apr 1, 2021 · 1d568ba · 1d568ba
2 parents c1472db + 3720e25
commit 1d568ba
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 119 deletions.
diff --git a/ele/element.py b/ele/element.py
@@ -250,8 +250,10 @@ def infer_element_from_string(string):
 elements = []
 with open(JSON_PATH) as json_file:
     elements_dict = json.load(json_file)
+    elements_dict = {int(key): value for key, value in elements_dict.items()}
 
-for element_name, element_properties in elements_dict.items():
+for atomic_number, element_properties in elements_dict.items():
+    assert atomic_number == element_properties["atomic number"]
     elements.append(
         Element(
             atomic_number=element_properties["atomic number"],