Skip to content

Add optional argument to reconnect for Rails 7.1+ compatibility #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Add optional argument to reconnect for Rails 7.1+ compatibility #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3c7b9
Add optional argument to reconnect for Rails 7.1+ compatibility
wojtha Apr 25, 2025
fc4c4f3
Change the default value
wojtha Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def reconnect
end

# Reconnects to the database.
def reconnect! # :nodoc:
def reconnect!(restore_transactions: false) # :nodoc:
super
_connection.reset!
rescue OracleEnhanced::ConnectionException => e
Expand Down
6 changes: 6 additions & 0 deletions spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
expect(ActiveRecord::Base.connection).to be_active
end

it "should be active after reconnection to database with restore_transactions: true" do
ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
ActiveRecord::Base.connection.reconnect!(restore_transactions: true)
expect(ActiveRecord::Base.connection).to be_active
end

it "should use database default cursor_sharing parameter value force by default" do
# Use `SYSTEM_CONNECTION_PARAMS` to query v$parameter
ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS)
Expand Down