Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Convey service integration when issuing presentations from the Holder app #60

Merged
merged 8 commits into from
Sep 24, 2020

Conversation

javiesses
Copy link
Contributor

@javiesses javiesses commented Sep 18, 2020

  • Convey service integration
  • New QR with convey://${cid}#${encryptionKey}
  • Solve secret box issues when encrypting
  • Convey login should be dispatched once the identity is created
  • Build for iOS
  • Remove tinyQr URL

The @rsksmart/rif-id-core official package will be added once the needed version is published
Created an issue (#66) to verify the CID retrieved from the convey service

@javiesses javiesses changed the title Convey service integration for presentations Convey service integration when issuing presentations from the Holder app Sep 18, 2020
@javiesses javiesses changed the base branch from data-vault-box to develop September 24, 2020 16:43
@javiesses javiesses marked this pull request as ready for review September 24, 2020 17:45
Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

import { removeCredential, createPresentation, checkStatusOfCredential } from '../operations';
import { selectServiceTokenByIdentity } from 'je-id-core/lib/reducers/authentication';
import { removeCredential } from '../operations';
import conveyConnect from './ConveyConnect'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

apps/IdentityApp/src/daf/AESEncryptionBox.ts Outdated Show resolved Hide resolved
@ilanolkies ilanolkies merged commit ba98d23 into develop Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the convey-integration branch September 24, 2020 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants