Removes pre lovell tests. Deletes unnecesary tests. Renames some test… #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
force-pushed
the
remove-pre-lovell700-tests
branch
from
acbdb17 to
489a2ff
Compare
nathanieliov
previously approved these changes
May 9, 2025
marcos-iov
previously approved these changes
May 13, 2025
marcos-iov
force-pushed
the
remove-pre-lovell700-tests
branch
from
489a2ff to
d4b9299
Compare
|
marcos-iov
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes pre lovell tests. Deletes unnecesary tests. Renames some test files.
Most of the "changed" files and test names were actually renamed.
There were some unnecessary test files that were deleted. No need for them to run again. Like the
tests/01_04_55-post_iris_call_receive_header.jsandtests/01_04_55-post_iris_call_receive_header.js,tests/05_00_04-powpeg_redeem_script.js, since they are duplicated.Actual changes are in
lib/bridge-provider.js,lib/tests/2wp.js,lib/tests/change-federation.js,test.js. The function inlib/assertions/2wp.jswas not being used.After renaming some files, CodeQL see them as new changes and forced me to do quick refactors like using
letinstead ofvar, etc.Since right now we are only doing 2 federation change, the test files
tests/01_07_01-2wp_after_latest_fork_activated.jsandtests/05_00_01-2wp-after-svp-federation-change.jsare no longer needed. These tests are already running. No need to run them again when there's no new fork or federation change.