Skip to content

better bootstrap.transition compatibility #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

better bootstrap.transition compatibility #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions jquery.transit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,18 @@
// Helper function to get the proper vendor property name.
// (`transition` => `WebkitTransition`)
function getVendorPropertyName(prop) {
// Handle unprefixed versions (FF16+, for example)
if (prop in div.style) return prop;


var prefixes = ['Moz', 'Webkit', 'O', 'ms'];
var prop_ = prop.charAt(0).toUpperCase() + prop.substr(1);

if (prop in div.style) { return prop; }

// Prefer vendor-prefixed property name over native for better interop with other libs
for (var i=0; i<prefixes.length; ++i) {
var vendorProp = prefixes[i] + prop_;
if (vendorProp in div.style) { return vendorProp; }
}

// Handle unprefixed versions (FF16+, for example)
if (prop in div.style) { return prop; }
}

// Helper function to check if transform3D is supported.
Expand All @@ -62,7 +62,9 @@
var isChrome = navigator.userAgent.toLowerCase().indexOf('chrome') > -1;

// Check for the browser's transitions support.
support.transition = getVendorPropertyName('transition');
// Create "transition" and "transform" as string objects so that they can be augmented with other properties.
// Bootstrap.transition, for example, creates $.support.transition = { end: support.transitionEnd }
support.transition = new String(getVendorPropertyName('transition'));
support.transitionDelay = getVendorPropertyName('transitionDelay');
support.transform = getVendorPropertyName('transform');
support.transformOrigin = getVendorPropertyName('transformOrigin');
Expand All @@ -87,6 +89,9 @@
$.support[key] = support[key];
}
}

// Now add the transition.end property expected by components dependent on bootstrap.transition
$.support.transition && ($.support.transition.end = support.transitionEnd);

// Avoid memory leak in IE.
div = null;
Expand Down