Skip to content

Changing labels from 'key' to 'getenv' #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Changing labels from 'key' to 'getenv' #229

wants to merge 5 commits into from

Conversation

nwstephens
Copy link

  • Changes all references from 'key' to 'getenv', which is slightly more descriptive.
  • Makes getenv case sensitive by removing 'toupper'.
  • Changes error message in Connect to be more descriptive.

@kevinushey
Copy link
Contributor

If we want something more descriptive than "key"; that is, we want to document this as specifically being tied to an environment variable, then I'd suggest calling it "envvar".

Also: are we sure we want to call this something other than "key"? What if we wanted to eventually look up "key" from something that wasn't an environment variable (e.g. some kind of special integration with keyring, or other future expansions in how we look up secrets on the system)

@nwstephens
Copy link
Author

We decided to change key to tag. Rolling those comments into #226 and closing this down.

@nwstephens nwstephens closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants