Fix: Login issue - Need to click login with google button twice #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is logged in - Added check for 'reauth' parameter in the URL. - Redirect to the login page if the user is already logged in.
rtBot
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
Powered by rtCamp's GitHub Actions Library
| @@ -112,6 +112,14 @@ function container(): Container { | |||
| function plugin(): Plugin { | |||
| static $plugin; | |||
|
|
|||
| $reauth = filter_input( INPUT_GET, 'reauth', FILTER_SANITIZE_STRING ); | |||
There was a problem hiding this comment.
Pathan-Amaankhan
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
• This PR resolves the issue where users need to press the “Login with Google” button twice to log in to the site.
• The issue occurs when the login cookie has expired.
Fixes/Covers