fix(init): skip redundant hook warning during rtk init#1013
Open
andeart wants to merge 1 commit intortk-ai:developfrom
Open
fix(init): skip redundant hook warning during rtk init#1013andeart wants to merge 1 commit intortk-ai:developfrom
andeart wants to merge 1 commit intortk-ai:developfrom
Conversation
When running `rtk init -g`, the hook check would fire before init had a chance to install the hook, printing a confusing "No hook installed - run rtk init -g" message. Replace that with an "Installing RTK hook" message for Init, matching how Gain already skips the check.
andeart
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1011.
maybe_warn()hook check when the command isInit, since it's about to install/update hooks itself[rtk] Installing RTK hookinstead of the misleading "No hook installed" warningGainalready skips the checkTest plan
rtk init -g --uninstallandrm ~/Library/Application\ Support/rtk/.hook_warn_last, then rebuild the binary.cargo fmt --all && cargo clippy --all-targets && cargo test. All pass.rtk init -goutput inspected. The message now reads "Installing RTK hook" instead of "No hook installed".