fix(curl): preserve valid JSON output for piping (#1015)#1016
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
fix(curl): preserve valid JSON output for piping (#1015)#1016pszymkowiak wants to merge 1 commit intodevelopfrom
pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
curl filter was converting JSON values to type names (extract_schema), producing invalid output that broke downstream JSON parsers (python, jq). Changes: - curl_cmd: pass JSON through unchanged instead of schema transform - json_cmd: quote object keys in extract_schema for valid JSON output - Added tests for JSON validity and quoted keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
rtk curl https://api.example/endpoint | python3 -c 'json.load(sys.stdin)'failed because:extract_schema()replaced values with type names (int,string,bool){name: string}instead of{"name": "string"})Fix
curl_cmd: JSON responses pass through unchanged (no schema transform)json_cmd: keys are now double-quoted inextract_schema()for other consumersTest plan
cargo test curl_cmd— 4 tests passcargo test json_cmd— 9 tests passrtk curl <api> | python3 -c 'json.load(...)'works